Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Code Engine binding resource and service_access secret format #4622

Merged
merged 5 commits into from
Jun 16, 2023
Merged

Add Code Engine binding resource and service_access secret format #4622

merged 5 commits into from
Jun 16, 2023

Conversation

michael-magrian
Copy link
Contributor

@michael-magrian michael-magrian commented Jun 12, 2023 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$  make testacc                                                                  
TF_ACC=1 go test -v $(go list ./... |grep -v 'vendor') 
?       github.com/IBM-Cloud/terraform-provider-ibm     [no test files]
?       github.com/IBM-Cloud/terraform-provider-ibm/ibm/acctest [no test files]
?       github.com/IBM-Cloud/terraform-provider-ibm/ibm/flex    [no test files]
?       github.com/IBM-Cloud/terraform-provider-ibm/ibm/provider        [no test files]
=== RUN   TestString
--- PASS: TestString (0.00s)
=== RUN   TestString_positiveIndex
--- PASS: TestString_positiveIndex (0.00s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/conns   (cached)
?       github.com/IBM-Cloud/terraform-provider-ibm/ibm/validate        [no test files]
?       github.com/IBM-Cloud/terraform-provider-ibm/version     [no test files]
=== RUN   TestAccIbmCodeEngineBindingDataSourceBasic
--- PASS: TestAccIbmCodeEngineBindingDataSourceBasic (77.09s)
=== RUN   TestAccIbmCodeEngineBuildDataSourceBasic
--- PASS: TestAccIbmCodeEngineBuildDataSourceBasic (13.24s)
=== RUN   TestAccIbmCodeEngineConfigMapDataSourceBasic
--- PASS: TestAccIbmCodeEngineConfigMapDataSourceBasic (12.75s)
=== RUN   TestAccIbmCodeEngineJobDataSourceBasic
--- PASS: TestAccIbmCodeEngineJobDataSourceBasic (12.84s)
=== RUN   TestAccIbmCodeEngineJobDataSourceExtended
--- PASS: TestAccIbmCodeEngineJobDataSourceExtended (12.14s)
=== RUN   TestAccIbmCodeEngineProjectDataSourceBasic
--- PASS: TestAccIbmCodeEngineProjectDataSourceBasic (7.52s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceGeneric
--- PASS: TestAccIbmCodeEngineSecretDataSourceGeneric (11.74s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceBasicAuth
--- PASS: TestAccIbmCodeEngineSecretDataSourceBasicAuth (12.57s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceRegistry
--- PASS: TestAccIbmCodeEngineSecretDataSourceRegistry (12.51s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceSSHAuth
--- PASS: TestAccIbmCodeEngineSecretDataSourceSSHAuth (12.78s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceTls
--- PASS: TestAccIbmCodeEngineSecretDataSourceTls (12.69s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceServiceAccess
--- PASS: TestAccIbmCodeEngineSecretDataSourceServiceAccess (13.18s)
=== RUN   TestAccIbmCodeEngineBindingBasic
--- PASS: TestAccIbmCodeEngineBindingBasic (77.01s)
=== RUN   TestAccIbmCodeEngineBuildBasic
--- PASS: TestAccIbmCodeEngineBuildBasic (11.66s)
=== RUN   TestAccIbmCodeEngineConfigMapBasic
--- PASS: TestAccIbmCodeEngineConfigMapBasic (25.40s)
=== RUN   TestAccIbmCodeEngineJobBasic
--- PASS: TestAccIbmCodeEngineJobBasic (22.01s)
=== RUN   TestAccIbmCodeEngineJobExtended
--- PASS: TestAccIbmCodeEngineJobExtended (24.90s)
=== RUN   TestAccIbmCodeEngineProjectBasic
--- PASS: TestAccIbmCodeEngineProjectBasic (72.48s)
=== RUN   TestAccIbmCodeEngineSecretGeneric
--- PASS: TestAccIbmCodeEngineSecretGeneric (23.71s)
=== RUN   TestAccIbmCodeEngineSecretBasicAuth
--- PASS: TestAccIbmCodeEngineSecretBasicAuth (24.69s)
=== RUN   TestAccIbmCodeEngineSecretRegistry
--- PASS: TestAccIbmCodeEngineSecretRegistry (22.64s)
=== RUN   TestAccIbmCodeEngineSecretSSHAuth
--- PASS: TestAccIbmCodeEngineSecretSSHAuth (22.51s)
=== RUN   TestAccIbmCodeEngineSecretTls
--- PASS: TestAccIbmCodeEngineSecretTls (23.56s)
=== RUN   TestAccIbmCodeEngineSecretServiceAccess
--- PASS: TestAccIbmCodeEngineSecretServiceAccess (14.16s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/codeengine      576.019s
...

@hkantare
Copy link
Collaborator

Can you fix the .secrets.baseline

@michael-magrian
Copy link
Contributor Author

Conflict resolved

@kavya498 kavya498 merged commit a4b62d9 into IBM-Cloud:master Jun 16, 2023
omaraibrahim pushed a commit to omaraibrahim/terraform-provider-ibm that referenced this pull request Jul 20, 2023
@michael-magrian @omaraibrahim
Add Code Engine binding resource and service_access secret format (…
492495a 
…IBM-Cloud#4622)

* Add support for CE service bindings

* Add CE secret format service_access

* Make CE build source_url optional IBM-Cloud#4480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavya498 kavya498 kavya498 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Engine Build "Source_url" should be optional
3 participants
@michael-magrian @hkantare @kavya498