Adding changes for replacement of key_protect parameter and adding the fix for 3394 #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the files I have linked above still make reference to using |
hkantare
reviewed
Jun 20, 2023
| } else { | ||
| d.Set("kms_key_crn", head.IBMSSEKPCrkId) | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Why are we seeting empty ?
| Description: "CRN of the key you want to use data at rest encryption", | ||
| Type: schema.TypeString, | ||
| ForceNew: true, | ||
| Optional: true, |
There was a problem hiding this comment.
Do we need to mark this as deprecated
There was a problem hiding this comment.
As of now we are not deprecating the key_protect parameter.
we will just be recommending new customers to use the new parameter.
hkantare
approved these changes
Jun 20, 2023
omaraibrahim
pushed a commit
to omaraibrahim/terraform-provider-ibm
that referenced
this pull request
Jul 20, 2023
…e fix for 3394 (IBM-Cloud#4618) * Adding the fix for issue 3394 and 1947 * Adding documentation for kms resource * Changes to kms example ,readme and test * Addressing the PR comment for code formatting * removing unnecessary changes from datasource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test results :
--- PASS: TestAccIBMCOSKPKmsParamValid (84.76s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 86.384s
--- PASS: TestAccIBMCOSKPKmsParamWithInvalidCRN (49.70s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 51.390s
--- PASS: TestAccIBMCOSHPCSKmsParamWithInvalidCRN (44.35s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 114.080s
--- PASS: TestAccIBMCOSHPCSKmsParamWithInvalidCRN (44.35s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos (cached)
--- PASS: TestAccIBMCOSKMSBothParamProvided (0.34s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 1.835s
KMS test cases
=== RUN TestAccIBMKMSResource_basic
--- PASS: TestAccIBMKMSResource_basic (242.06s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kms 244.089s