-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add optional secondary storage fields to IKS cluster and workerpool #4255
add optional secondary storage fields to IKS cluster and workerpool #4255
Conversation
17e1064
to
ffc917d
Compare
ffc917d
to
8ad86d7
Compare
Computed: true, | ||
}, | ||
"count": { | ||
Type: schema.TypeString, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be schema.TypeInt
? Or is it string to match the underlying API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, count and size should be int
|
||
Nested scheme for `secondary_storage`: | ||
- `name` - (String) The name of the secondary storage. | ||
- `count` - (String) The device count of the secondary storage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see in this block that worker_count
is listed as (String)
yet the schema has a TypeInt
in the worker pool data source. I know this PR hasn't introduced it, but I think the inconsistency needs addressing. Can a separate issue be raised to review it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created an issue to track it
b5ea47a
to
5d241ba
Compare
cf53a2e
to
23fe839
Compare
"secondary_storage": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this computed also? If user doesn't create any secondary storage does API set back any default value
…BM-Cloud#4255) * add user defined secondary storage support to vpc cluster and workerpool * tc fix for non secondarystorage case * update docs and descriptions * remove userdefined string, count and size is now integer in secondarystorage schema * update docs Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com>
…BM-Cloud#4255) * add user defined secondary storage support to vpc cluster and workerpool * tc fix for non secondarystorage case * update docs and descriptions * remove userdefined string, count and size is now integer in secondarystorage schema * update docs Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com>
* Added new service Metrics Router to repo * Updated secret baseline file * Updated baseline file with is_secret * Changed sdk repo path * Fixed a couple typos Found a couple typos when I was deploying a cluster. This should fix it. * Updates to tekton-pipeline support (#4235) * fix(tekton): pos-GA updates * chore(tekton): update Go SDK version * fix(tekton): finalise tekton updates Signed-off-by: Brian Gleeson <brian.gleeson@ie.ibm.com> * fix(tekton): Address Worker and href feedback Signed-off-by: Brian Gleeson <brian.gleeson@ie.ibm.com> * add ForceNew tag to OS fields (#4279) * add ForceNew tag to OS fileds, updated doc * add forces new resource tag to the doc Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com> * warning state in pending list, WARN logs about warning and critical s… (#4283) * warning state in pending list, WARN logs about warning and critical states * added extra clarification in docs about wait_till Normal option * Continuous Delivery - Git PAT support (#4276) * Git PAT support * Fix example * vpc address prefix and subnet doc fix * Fix #4132: fix values_metadata argument in schematics resource * enhancement(vpc-go-sdk) : Migration to latest 0.30.0 * fix(networkacl) : made name optional to allow create_before_destroy * Remove certificate manager service support * Fix ibm_appid_cloud_directory_user missing userName * update provider metadata * update CHANGELOG * Bump up version to 1.50.0-beta0 * add optional secondary storage fields to IKS cluster and workerpool (#4255) * add user defined secondary storage support to vpc cluster and workerpool * tc fix for non secondarystorage case * update docs and descriptions * remove userdefined string, count and size is now integer in secondarystorage schema * update docs Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com> * CD: Field description updates for PAT * refactor(Cloud Databases) autoscaling uses cloud-databases-go-sdk (#4218) * fix: documentation fix for ibm_cm_object resource * dependabot: bump github/issue-labeler from 2.5 to 2.6 Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 2.5 to 2.6. - [Release notes](https://github.com/github/issue-labeler/releases) - [Commits](github/issue-labeler@v2.5...v2.6) --- updated-dependencies: - dependency-name: github/issue-labeler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore(tekton): bump Tekton Go SDK version * dependabot: bump actions/checkout from 3.2.0 to 3.3.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.2.0...v3.3.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * update tags from globaltags to search API * update metadata * update CHANGELOG * Bump up version to 1.50.0 * Adding new destination , integration and updating subscription resources for event notifications (#4321) * adding new destination, updating email subscription and integrayion resources for event notification service * Update go.mod updating event notification package * Update go.sum updating event-notifications entry in go.sum * Deprecate: retain schema and remove code * Remove deprecated resource notification for VPC route resource (#4323) * removal notification for vpc route * updated the release number: v1.51.0 - removal notification v1.52.0 - resource is removed * Single node infrastructure added (#4269) * Single node infrastructure added * Variable fix * single-node code added * Empty-Commit to run tests with updated sdk. * Updated sdk version * Added code for data recource * Added documentation * Added documentation * Corrected typo * Added test case for new variable * Removed single-node resource. Added single-node parameters to existing create cluster resource. * Changes reflecting PR comments. * Added test case for single node clusters. Updated variables. * Updated version * fix: allow data to be set/updated when already unquoted * refactor(Cloud Databases): configuration uses cloud-databases-go-sdk (#4234) * refactor(Cloud Databases): configuration uses cloud-databases-go-sdk * address PR comments * remove unused bluemix client --------- Signed-off-by: Brian Gleeson <brian.gleeson@ie.ibm.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: ElliotG <elliotgraebert@gmail.com> Co-authored-by: Brian Gleeson <brian.gleeson@ie.ibm.com> Co-authored-by: Zoltán Illés <zoltan.illes@live.com> Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com> Co-authored-by: attilatabori <92513370+attilatabori@users.noreply.github.com> Co-authored-by: gmarjoram <marjoram@ie.ibm.com> Co-authored-by: Deepak Selvakumar <Deepak.Selvakumar@ibm.com> Co-authored-by: hkavya26 <hkavya26@in.ibm.com> Co-authored-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com> Co-authored-by: hkantare <hkantare@in.ibm.com> Co-authored-by: alex hemard <alexhemard@gmail.com> Co-authored-by: Ben Buchanan <buchanan@ibm.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Divya-Singh1693 <68578534+Divya-Singh1693@users.noreply.github.com> Co-authored-by: Sandeep S <Sandeep.S1@ibm.com> Co-authored-by: Bhavesh Shrivastav <91112322+BShrivastav@users.noreply.github.com> Co-authored-by: Carl Petersson <110849631+cappetersson@users.noreply.github.com>
* Added new service Metrics Router to repo * Updated secret baseline file * Updated baseline file with is_secret * Changed sdk repo path * Fixed a couple typos Found a couple typos when I was deploying a cluster. This should fix it. * Updates to tekton-pipeline support (#4235) * fix(tekton): pos-GA updates * chore(tekton): update Go SDK version * fix(tekton): finalise tekton updates Signed-off-by: Brian Gleeson <brian.gleeson@ie.ibm.com> * fix(tekton): Address Worker and href feedback Signed-off-by: Brian Gleeson <brian.gleeson@ie.ibm.com> * add ForceNew tag to OS fields (#4279) * add ForceNew tag to OS fileds, updated doc * add forces new resource tag to the doc Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com> * warning state in pending list, WARN logs about warning and critical s… (#4283) * warning state in pending list, WARN logs about warning and critical states * added extra clarification in docs about wait_till Normal option * Continuous Delivery - Git PAT support (#4276) * Git PAT support * Fix example * vpc address prefix and subnet doc fix * Fix #4132: fix values_metadata argument in schematics resource * enhancement(vpc-go-sdk) : Migration to latest 0.30.0 * fix(networkacl) : made name optional to allow create_before_destroy * Remove certificate manager service support * Fix ibm_appid_cloud_directory_user missing userName * update provider metadata * update CHANGELOG * Bump up version to 1.50.0-beta0 * add optional secondary storage fields to IKS cluster and workerpool (#4255) * add user defined secondary storage support to vpc cluster and workerpool * tc fix for non secondarystorage case * update docs and descriptions * remove userdefined string, count and size is now integer in secondarystorage schema * update docs Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com> * CD: Field description updates for PAT * refactor(Cloud Databases) autoscaling uses cloud-databases-go-sdk (#4218) * fix: documentation fix for ibm_cm_object resource * dependabot: bump github/issue-labeler from 2.5 to 2.6 Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 2.5 to 2.6. - [Release notes](https://github.com/github/issue-labeler/releases) - [Commits](github/issue-labeler@v2.5...v2.6) --- updated-dependencies: - dependency-name: github/issue-labeler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore(tekton): bump Tekton Go SDK version * dependabot: bump actions/checkout from 3.2.0 to 3.3.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.2.0...v3.3.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * update tags from globaltags to search API * update metadata * update CHANGELOG * Bump up version to 1.50.0 * Adding new destination , integration and updating subscription resources for event notifications (#4321) * adding new destination, updating email subscription and integrayion resources for event notification service * Update go.mod updating event notification package * Update go.sum updating event-notifications entry in go.sum * Deprecate: retain schema and remove code * Remove deprecated resource notification for VPC route resource (#4323) * removal notification for vpc route * updated the release number: v1.51.0 - removal notification v1.52.0 - resource is removed * Single node infrastructure added (#4269) * Single node infrastructure added * Variable fix * single-node code added * Empty-Commit to run tests with updated sdk. * Updated sdk version * Added code for data recource * Added documentation * Added documentation * Corrected typo * Added test case for new variable * Removed single-node resource. Added single-node parameters to existing create cluster resource. * Changes reflecting PR comments. * Added test case for single node clusters. Updated variables. * Updated version * fix: allow data to be set/updated when already unquoted * refactor(Cloud Databases): configuration uses cloud-databases-go-sdk (#4234) * refactor(Cloud Databases): configuration uses cloud-databases-go-sdk * address PR comments * remove unused bluemix client * Adopted new API changes * updated .secrets.baseline * fix formating provider.go * Corrected the testing target CRN * Modified the input table of content in README * Added more examples * minor changes in service names * Picking mr gosdk from master * Added info on settings id * fixing issues * Fix removal of permitted_target_regions * Fix crashing issue due to empty targets * Added info on first time setting of primary_metadata_region * Added changes as per comments --------- Signed-off-by: Brian Gleeson <brian.gleeson@ie.ibm.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: ElliotG <elliotgraebert@gmail.com> Co-authored-by: Brian Gleeson <brian.gleeson@ie.ibm.com> Co-authored-by: Zoltán Illés <zoltan.illes@live.com> Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com> Co-authored-by: attilatabori <92513370+attilatabori@users.noreply.github.com> Co-authored-by: gmarjoram <marjoram@ie.ibm.com> Co-authored-by: Deepak Selvakumar <Deepak.Selvakumar@ibm.com> Co-authored-by: hkavya26 <hkavya26@in.ibm.com> Co-authored-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com> Co-authored-by: hkantare <hkantare@in.ibm.com> Co-authored-by: alex hemard <alexhemard@gmail.com> Co-authored-by: Ben Buchanan <buchanan@ibm.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Divya-Singh1693 <68578534+Divya-Singh1693@users.noreply.github.com> Co-authored-by: Sandeep S <Sandeep.S1@ibm.com> Co-authored-by: Bhavesh Shrivastav <91112322+BShrivastav@users.noreply.github.com> Co-authored-by: Carl Petersson <110849631+cappetersson@users.noreply.github.com>
* Added new service Metrics Router to repo * Updated secret baseline file * Updated baseline file with is_secret * Changed sdk repo path * Fixed a couple typos Found a couple typos when I was deploying a cluster. This should fix it. * Updates to tekton-pipeline support (IBM-Cloud#4235) * fix(tekton): pos-GA updates * chore(tekton): update Go SDK version * fix(tekton): finalise tekton updates Signed-off-by: Brian Gleeson <brian.gleeson@ie.ibm.com> * fix(tekton): Address Worker and href feedback Signed-off-by: Brian Gleeson <brian.gleeson@ie.ibm.com> * add ForceNew tag to OS fields (IBM-Cloud#4279) * add ForceNew tag to OS fileds, updated doc * add forces new resource tag to the doc Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com> * warning state in pending list, WARN logs about warning and critical s… (IBM-Cloud#4283) * warning state in pending list, WARN logs about warning and critical states * added extra clarification in docs about wait_till Normal option * Continuous Delivery - Git PAT support (IBM-Cloud#4276) * Git PAT support * Fix example * vpc address prefix and subnet doc fix * Fix IBM-Cloud#4132: fix values_metadata argument in schematics resource * enhancement(vpc-go-sdk) : Migration to latest 0.30.0 * fix(networkacl) : made name optional to allow create_before_destroy * Remove certificate manager service support * Fix ibm_appid_cloud_directory_user missing userName * update provider metadata * update CHANGELOG * Bump up version to 1.50.0-beta0 * add optional secondary storage fields to IKS cluster and workerpool (IBM-Cloud#4255) * add user defined secondary storage support to vpc cluster and workerpool * tc fix for non secondarystorage case * update docs and descriptions * remove userdefined string, count and size is now integer in secondarystorage schema * update docs Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com> * CD: Field description updates for PAT * refactor(Cloud Databases) autoscaling uses cloud-databases-go-sdk (IBM-Cloud#4218) * fix: documentation fix for ibm_cm_object resource * dependabot: bump github/issue-labeler from 2.5 to 2.6 Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 2.5 to 2.6. - [Release notes](https://github.com/github/issue-labeler/releases) - [Commits](github/issue-labeler@v2.5...v2.6) --- updated-dependencies: - dependency-name: github/issue-labeler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore(tekton): bump Tekton Go SDK version * dependabot: bump actions/checkout from 3.2.0 to 3.3.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.2.0...v3.3.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * update tags from globaltags to search API * update metadata * update CHANGELOG * Bump up version to 1.50.0 * Adding new destination , integration and updating subscription resources for event notifications (IBM-Cloud#4321) * adding new destination, updating email subscription and integrayion resources for event notification service * Update go.mod updating event notification package * Update go.sum updating event-notifications entry in go.sum * Deprecate: retain schema and remove code * Remove deprecated resource notification for VPC route resource (IBM-Cloud#4323) * removal notification for vpc route * updated the release number: v1.51.0 - removal notification v1.52.0 - resource is removed * Single node infrastructure added (IBM-Cloud#4269) * Single node infrastructure added * Variable fix * single-node code added * Empty-Commit to run tests with updated sdk. * Updated sdk version * Added code for data recource * Added documentation * Added documentation * Corrected typo * Added test case for new variable * Removed single-node resource. Added single-node parameters to existing create cluster resource. * Changes reflecting PR comments. * Added test case for single node clusters. Updated variables. * Updated version * fix: allow data to be set/updated when already unquoted * refactor(Cloud Databases): configuration uses cloud-databases-go-sdk (IBM-Cloud#4234) * refactor(Cloud Databases): configuration uses cloud-databases-go-sdk * address PR comments * remove unused bluemix client * Adopted new API changes * updated .secrets.baseline * fix formating provider.go * Corrected the testing target CRN * Modified the input table of content in README * Added more examples * minor changes in service names * Picking mr gosdk from master * Added info on settings id * fixing issues * Fix removal of permitted_target_regions * Fix crashing issue due to empty targets * Added info on first time setting of primary_metadata_region * Added changes as per comments --------- Signed-off-by: Brian Gleeson <brian.gleeson@ie.ibm.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: ElliotG <elliotgraebert@gmail.com> Co-authored-by: Brian Gleeson <brian.gleeson@ie.ibm.com> Co-authored-by: Zoltán Illés <zoltan.illes@live.com> Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com> Co-authored-by: attilatabori <92513370+attilatabori@users.noreply.github.com> Co-authored-by: gmarjoram <marjoram@ie.ibm.com> Co-authored-by: Deepak Selvakumar <Deepak.Selvakumar@ibm.com> Co-authored-by: hkavya26 <hkavya26@in.ibm.com> Co-authored-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com> Co-authored-by: hkantare <hkantare@in.ibm.com> Co-authored-by: alex hemard <alexhemard@gmail.com> Co-authored-by: Ben Buchanan <buchanan@ibm.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Divya-Singh1693 <68578534+Divya-Singh1693@users.noreply.github.com> Co-authored-by: Sandeep S <Sandeep.S1@ibm.com> Co-authored-by: Bhavesh Shrivastav <91112322+BShrivastav@users.noreply.github.com> Co-authored-by: Carl Petersson <110849631+cappetersson@users.noreply.github.com>
Community Note
Relates OR Closes #0000
Output from acceptance testing: