Deprecate key_protect_key_id

[omaraibrahim]

key_protect_key_id is deprecated and has been replaced by backup_encryption_key_crn. Refactored code to add deprecated to key_protect_key_id. Updated docs as well.

Note that functionally no changes have been made.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccIBMDatabaseDataSource_basic (585.66s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	586.688s
...

---

Commands being run:

data "ibm_database" "test" {
  name = "20-056 Lorna Databases for MongoDB-iy"
  location = "us-south"
}

output "the_good_stuff" {
  value = data.ibm_database.test.platform_options
}

Before the changes

Changes to Outputs:
  + the_good_stuff = [
      + {
          + backup_encryption_key_crn = ""
          + disk_encryption_key_crn   = "crn:v1:bluemix:public:kms:au-syd:a/40ddc34a953a8c02f10987b59085b60e:673d0877-db09-4b48-ace8-28e677705ca2:key:8c80be4e-482a-42c3-803b-54f4d84abf85"
          + key_protect_key_id        = "crn:v1:bluemix:public:kms:au-syd:a/40ddc34a953a8c02f10987b59085b60e:673d0877-db09-4b48-ace8-28e677705ca2:key:8c80be4e-482a-42c3-803b-54f4d84abf85"
        },
    ]

After the changes

Changes to Outputs:
  + the_good_stuff = [
      + {
          + backup_encryption_key_crn = ""
          + disk_encryption_key_crn   = "crn:v1:bluemix:public:kms:au-syd:a/40ddc34a953a8c02f10987b59085b60e:673d0877-db09-4b48-ace8-28e677705ca2:key:8c80be4e-482a-42c3-803b-54f4d84abf85"
          + key_protect_key_id        = "crn:v1:bluemix:public:kms:au-syd:a/40ddc34a953a8c02f10987b59085b60e:673d0877-db09-4b48-ace8-28e677705ca2:key:8c80be4e-482a-42c3-803b-54f4d84abf85"
        },
    ]

[obai-1]

Pls add a note with details of tests showing that the change is not forcing users to update their existing configurations, and also not interfering with tfstate.

[omaraibrahim]

@obai-1 updated :)