Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for lb pool member weight (optional attribute) assigned 0 when not provided #3685

Merged
merged 3 commits into from
Apr 7, 2022

Conversation

BShrivastav
Copy link
Contributor

@BShrivastav BShrivastav commented Mar 23, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISLBPoolMember_basic_opt_weight_check'
=== RUN   TestAccIBMISLBPoolMember_basic_opt_weight_check
--- PASS: TestAccIBMISLBPoolMember_basic_opt_weight_check (807.13s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc	808.130s

make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISLBPoolMember_basic'
=== RUN   TestAccIBMISLBPoolMember_basic
--- PASS: TestAccIBMISLBPoolMember_basic (1068.65s)

make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISLBPoolMember_basic_network'
--- PASS: TestAccIBMISLBPoolMember_basic_network (1045.05s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc	1046.405s

...

Fix for optional weight attr set to 0 when not provided.
@BShrivastav BShrivastav changed the title Added fix for lb pool member weight getting 0 assigned when not provided Added fix for lb pool member weight (optional attribute) assigned 0 when not provided Mar 23, 2022
@hkantare
Copy link
Collaborator

Can you please share the test case results for other testcases

@hkantare
Copy link
Collaborator

In docs my be can you add the if the weight is not provided it creates with a default of "50"

weight default info added in docs.
@hkantare hkantare merged commit cf07c8b into IBM-Cloud:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants