Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of Transaction-Id #3518

Merged
merged 2 commits into from
May 19, 2022
Merged

Support of Transaction-Id #3518

merged 2 commits into from
May 19, 2022

Conversation

Rajesh-Pirati
Copy link
Contributor

@Rajesh-Pirati Rajesh-Pirati commented Jan 24, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #3224

Output from acceptance testing:

service policy output
image
access-group policies
image
user policies
image
Trusted profile policies
image
Authorization policies
image
image
image
image
image
image
DataSource
image

@kavya498
Copy link
Collaborator

Kindly migrate to latest code changes..
Thanks

@Rajesh-Pirati Rajesh-Pirati force-pushed the transaction_id branch 4 times, most recently from 6852b17 to 68608b7 Compare April 28, 2022 11:10
@Rajesh-Pirati Rajesh-Pirati marked this pull request as ready for review April 28, 2022 12:18
@hkantare
Copy link
Collaborator

General comment across all files can we make sure we check resp != nil and access the element at zeroth element inorder to avoid any nil pointer exception in rare conditions

@hkantare hkantare merged commit 3a58b3d into IBM-Cloud:master May 19, 2022
@Rajesh-Pirati Rajesh-Pirati deleted the transaction_id branch May 19, 2022 12:19
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
@Rajesh-Pirati @SunithaGudisagarIBM1
Support of Transaction-Id (IBM-Cloud#3518)
50d9998 
* Support of Transaction-Id

* Fix testcase failure and added missing code after rebase. Incorporated review comments
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
@Rajesh-Pirati @SunithaGudisagarIBM1
Support of Transaction-Id (IBM-Cloud#3518)
cb8fd54 
* Support of Transaction-Id

* Fix testcase failure and added missing code after rebase. Incorporated review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction-Id support by resource
3 participants
@Rajesh-Pirati @kavya498 @hkantare