Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(is_region): made name as optional in ibm_is_region datasource #3431

Merged
merged 1 commit into from
Mar 17, 2022
Merged

enhancement(is_region): made name as optional in ibm_is_region datasource #3431

merged 1 commit into from
Mar 17, 2022

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Dec 14, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #1258

Output from acceptance testing:

--- PASS: TestAccIBMISRegionDataSource_basic (35.59s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 40.186s

@uibm uibm force-pushed the is-region-datasource-name branch 2 times, most recently from a46339e to a458962 Compare December 14, 2021 08:15
@uibm uibm force-pushed the is-region-datasource-name branch from 2c1ccda to d3722ba Compare January 24, 2022 23:19
@uibm uibm force-pushed the is-region-datasource-name branch from 55241b1 to 48477e4 Compare February 9, 2022 08:11
@uibm
Copy link
Collaborator Author

uibm commented Feb 9, 2022

rebased

=== RUN   TestAccIBMISRegionDataSource_basic
--- PASS: TestAccIBMISRegionDataSource_basic (29.89s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     31.770s

@uibm
Copy link
Collaborator Author

uibm commented Mar 3, 2022

rebased

--- PASS: TestAccIBMISRegionDataSource_basic (22.70s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     24.871s

@uibm uibm force-pushed the is-region-datasource-name branch from e8dbc57 to d174b47 Compare March 3, 2022 12:16
@hkantare hkantare merged commit 70ad264 into IBM-Cloud:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ibm_is_region make name optional
2 participants
@uibm @hkantare