add proxy_protocol feature for load_balancer #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
Mar 10, 2021
| @@ -74,6 +75,12 @@ func resourceIBMISLBListener() *schema.Resource { | |||
| Description: "certificate instance for the Loadbalancer", | |||
| }, | |||
|
|
|||
| isLBListenerAcceptProxyProtocol: { | |||
| Type: schema.TypeBool, | |||
| Optional: true, | |||
There was a problem hiding this comment.
Can we add default value as "false" as per API docs
| @@ -65,6 +65,7 @@ The following arguments are supported: | |||
| * `default_pool` - (Optional, string) The load balancer pool unique identifier. | |||
| * `certificate_instance` - (Optional, string) CRN of the certificate instance. | |||
| * `connection_limit` - (Optional, int) The connection limit of the listener. Valid range 1 to 15000. Network load balancer does not support `connection_limit` argument. | |||
| * `accept_proxy_protocol` - (Optional, boolean) If true, listener will forward PROXY protocol information. Supported by load balancers in the application family otherwise false. | |||
There was a problem hiding this comment.
Add the default value also
| @@ -69,6 +71,7 @@ The following arguments are supported: | |||
| * `health_monitor_port` - (Optional, int) The health check port number | |||
| * `session_persistence_type` - (Optional, string) The session persistence type, Enumeration type: source_ip, http_cookie, app_cookie | |||
| * `session_persistence_cookie_name` - (Optional, string) Session persistence cookie name. This option is applicable only to --session-persistence-type | |||
| * `proxy_protocol` - (Otpional, string) The PROXY protocol setting for this pool. Supported by load balancers in the application family otherwise disabled. | |||
There was a problem hiding this comment.
Add the supported values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=== RUN TestAccIBMISLBPool_basic
--- PASS: TestAccIBMISLBPool_basic (569.11s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm 570.401s
=== RUN TestAccIBMISLBListener_basic
--- PASS: TestAccIBMISLBListener_basic (605.86s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm 607.333s