Added resource for ibm_pi_snapshot + cleaned up pi_instance #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hkantare Can we expect this in the next release? Thanks. |
hkantare
reviewed
Sep 9, 2020
ibm/resource_ibm_pi_network_port.go
Outdated
|
|
||
| helpers.PINetworkPortIPAddress: { | ||
| "ipaddress": { |
There was a problem hiding this comment.
The required and option fields for all power resources are having this naming convnetion helpers.PINetworkPortIPAddress (pi_XXXX) I think please follow same here also
| @@ -47,6 +47,10 @@ func dataSourceIBMPIImage() *schema.Resource { | |||
| Type: schema.TypeString, | |||
| Computed: true, | |||
| }, | |||
| "storage_type": { | |||
There was a problem hiding this comment.
Add this storage_type attribute to the docs of both resource and datasources pi_image
| }, | ||
|
|
||
| "description": { | ||
| Type: schema.TypeString, |
There was a problem hiding this comment.
Description is optional field...can we add the helper string pi_description and in create don't set the default description if it's not set by user
if d.Get(description) == "" {
description = "Testing from Terraform"
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.