-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
…t to run both together
@sargentfrancesca I’ve no idea if this is of any use, but I thought I’d just flag this comment / demo for building and deploying the reference site using Travis CI: It probably won’t work with the latest python3 changes, but I guess it wouldn’t take much to fix. |
deployment/build_iati_standard.sh
Outdated
rm -Rf pyenv/ | ||
fi | ||
|
||
if [ "$PYTHON_2" = true ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good, do we want to keep it though? should we not be a bit more annoying and just force the users to have py3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this flag can be removed when py3 upgrades have been merged and deployed, otherwise not needed!
This is really good @sargentfrancesca 👍 |
@andylolz ah, thank you so much! This is great, and really useful. We're still scoping how our continuous delivery might look for the SSOT - the amendments here are as close as I could get to consolidating what exists in a more robust way whilst not abstracting too far from the purpose of this set of updates. We're actually resuming work on containerising the IATI Standard Website (IATI/IATI-Standard-Website@master...add-docker) at the moment as a starting point for consolidating build and deploy processes throughout our tools. I'm sandpitting Dokku as a PaaS (IATI/IATI-Standard-Website@add-docker...add-dokku). I can see your snippet being really useful when we finally put this into practise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.