Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always compress in dev mode. #790

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Always compress in dev mode. #790

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2024

@ghost ghost requested a review from Bjwebb November 8, 2024 08:02
@ghost ghost self-assigned this Nov 8, 2024
@ghost
Copy link
Author

ghost commented Nov 8, 2024

There is a question of whether you might sometimes want to run dev with no compress.

But currently you can't without editing files anyway, so PR at least makes the local dev env runnable with no file editing needed.

@ghost ghost force-pushed the issue-780 branch from 7ae478b to 3fdfd60 Compare November 8, 2024 08:11
@ghost ghost marked this pull request as draft November 8, 2024 08:19
@ghost
Copy link
Author

ghost commented Nov 8, 2024

Ok this works for running stuff locally but breaks in tests. I'll come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bjwebb Bjwebb Awaiting requested review from Bjwebb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jarofgreen