Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: Use pip-tools #126

Merged
merged 2 commits into from
Mar 20, 2024
Merged

requirements: Use pip-tools #126

merged 2 commits into from
Mar 20, 2024

Conversation

Bjwebb
Copy link
Contributor

@Bjwebb Bjwebb commented Jan 19, 2024

This ensures that all requirements are pinned.

@Bjwebb Bjwebb requested a review from a user January 19, 2024 11:15
@ghost
Copy link

ghost commented Jan 19, 2024

If we are switching to this do we also need to do something about the automatically committing upgrade bot, or will that keep working normally?

@Bjwebb
Copy link
Contributor Author

Bjwebb commented Jan 19, 2024

I think that should keep working. The initial PR is done by GitHub's dependabot, which seems to have automatically detected pip-tools support (e.g. this cove PR, which also correctly suggests a Django version within the range specified in the requirements.in).

@ghost
Copy link

ghost commented Jan 19, 2024

Ok.

Just noted tho, the CI and Release is python 3.9 and this was 3.10 - we should standardise.

Apart from that it looks good tho.

This ensures that all requirements are pinned.
@Bjwebb
Copy link
Contributor Author

Bjwebb commented Mar 20, 2024

I've updated the CI and Release GitHub workflows to use 3.10, as that's also what the latest Ubuntu LTS (22.04) has.

@Bjwebb Bjwebb merged commit 7a88ac0 into master Mar 20, 2024
2 checks passed
@Bjwebb Bjwebb deleted the pip-tools branch March 20, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant