Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow convert_gwp() with metric=None when in/out species are identical #21

Merged
merged 10 commits into from
Apr 21, 2020
Merged

Allow convert_gwp() with metric=None when in/out species are identical #21

merged 10 commits into from
Apr 21, 2020

Conversation

khaeru
Copy link
Contributor

@khaeru khaeru commented Apr 15, 2020 •
edited
Loading

Closes #20.

@khaeru khaeru self-assigned this Apr 15, 2020
@khaeru khaeru requested a review from danielhuppmann April 15, 2020 08:45
@khaeru khaeru mentioned this pull request Apr 15, 2020
Merged
3 tasks
danielhuppmann
danielhuppmann approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @khaeru!

@khaeru khaeru merged commit 5d1e20f into master Apr 21, 2020
@khaeru khaeru deleted the issue/20 branch April 21, 2020 11:44
@danielhuppmann danielhuppmann mentioned this pull request May 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhuppmann danielhuppmann danielhuppmann approved these changes

Assignees

@khaeru khaeru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow convert_gwp() with metric=None when in/out species are identical
2 participants
@khaeru @danielhuppmann