-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error message when initializing with invisible columns #634
Better error message when initializing with invisible columns #634
Conversation
Codecov Report
@@ Coverage Diff @@
## main #634 +/- ##
=====================================
Coverage 94.6% 94.6%
=====================================
Files 57 57
Lines 5651 5658 +7
=====================================
+ Hits 5347 5355 +8
+ Misses 304 303 -1
Continue to review full report at Codecov.
|
Since this is a draft PR, should I review this or is it not ready yet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
A few small comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
One small stylistic comment below.
Co-authored-by: Philip Hackstock <p.hackstock@gmx.at>
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription of PR
Per a user support request for the Scenario Explorer upload, we noticed that an xlsx file which has an "invisible" column (e.g., a whitespace in a column to the right of the data) raises a generic
This is not really helpful to users.
This PR restructures the try-except such that a user will receive a more intelligible error message including the column name: