-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen xlrd requirement #572
Conversation
Codecov Report
@@ Coverage Diff @@
## main #572 +/- ##
=====================================
Coverage 93.7% 93.7%
=====================================
Files 50 50
Lines 5332 5334 +2
=====================================
+ Hits 4997 4999 +2
Misses 335 335
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to not work with xlrd==2.0.0
- maybe require xlrd>=2.0.1
instead?
Had to make some tweaks to make sure engine passing worked, let's see what the CI says |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @znicholls!
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Please confirm that this PR has done the following:
Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
Description of PR
Loosen the pinning of xlrd. The pin isn't needed and it's causing issues for downstream users (e.g. attempts to make openscm-runner a conda package conda-forge/staged-recipes#15573 (comment)). It would be great if these changes could be propagated to conda and pypi fairly quickly as a bug fix.