-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap time for year keeping subannual resolution #557
Swap time for year keeping subannual resolution #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
Codecov Report
@@ Coverage Diff @@
## main #557 +/- ##
=====================================
Coverage 93.6% 93.6%
=====================================
Files 48 50 +2
Lines 5242 5277 +35
=====================================
+ Hits 4909 4944 +35
Misses 333 333
Continue to review full report at Codecov.
|
Thanks for the very swift review, @znicholls! |
Please confirm that this PR has done the following:
Name of contributors Added to AUTHORS.rstDescription of PR
This PR migrates a feature first developed in https://github.com/openENTRANCE/nomenclature to split out the "time" column of an IamDataFrame into a year column (as int) plus keeping the information on the sub-annual resolution as a new extra-column "subannual".