Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap time for year keeping subannual resolution #557

Merged
merged 11 commits into from
Jul 7, 2021

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Jul 6, 2021

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR migrates a feature first developed in https://github.com/openENTRANCE/nomenclature to split out the "time" column of an IamDataFrame into a year column (as int) plus keeping the information on the sub-annual resolution as a new extra-column "subannual".

@danielhuppmann danielhuppmann added the datetime Compatibility with `datetime` time format label Jul 6, 2021
@danielhuppmann danielhuppmann requested a review from znicholls July 6, 2021 09:12
@danielhuppmann danielhuppmann self-assigned this Jul 6, 2021
Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

tests/test_time.py Outdated Show resolved Hide resolved
tests/test_time.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #557 (52e3e4c) into main (6de47cc) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #557   +/-   ##
=====================================
  Coverage   93.6%   93.6%           
=====================================
  Files         48      50    +2     
  Lines       5242    5277   +35     
=====================================
+ Hits        4909    4944   +35     
  Misses       333     333           
Impacted Files Coverage Δ
setup.py 0.0% <ø> (ø)
tests/test_core.py 100.0% <ø> (ø)
pyam/core.py 94.2% <100.0%> (-0.2%) ⬇️
pyam/index.py 98.0% <100.0%> (+0.1%) ⬆️
pyam/time.py 100.0% <100.0%> (ø)
tests/test_time.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de47cc...52e3e4c. Read the comment docs.

@danielhuppmann danielhuppmann marked this pull request as ready for review July 6, 2021 10:01
@danielhuppmann
Copy link
Member Author

Thanks for the very swift review, @znicholls!

@danielhuppmann danielhuppmann merged commit dc3d967 into IAMconsortium:main Jul 7, 2021
danielhuppmann added a commit to danielhuppmann/pyam that referenced this pull request Jul 7, 2021
@danielhuppmann danielhuppmann deleted the time/swap_subannual branch July 8, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datetime Compatibility with `datetime` time format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants