-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hide unneeded logging messages #546
hide unneeded logging messages #546
Conversation
Codecov Report
@@ Coverage Diff @@
## main #546 +/- ##
=====================================
Coverage 93.6% 93.6%
=====================================
Files 48 48
Lines 5285 5288 +3
=====================================
+ Hits 4947 4950 +3
Misses 338 338
Continue to review full report at Codecov.
|
Nice work, thanks @pjuergens! Two requests:
|
Well, most of the work was yours :) I did the refactoring and hope that all the tests will run through now :) |
@danielhuppmann do you know why some tests are failing now? They seem to be in parts of the code where I didn't change anything |
Well, I think this is a good mode of operation: you (or other intermediate-expert users) identify an issue, receive some guidance from admins like me, then make a PR fixing this... About the issue, the IIASA database crashed before lunch, so the unit tests checking the iiasa.Connection module failed. I restarted the tests, everything passes now. Ready for review? PS: there is a skip-if-IIASA-db-API-fails decorator if it cannot be reached entirely, but I guess this doesn't work when the database times out (rather than being offline)... Line 17 in 0989fdd
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pjuergens for doing some clean-up of the codebase beyond your immediate issue!
Please confirm that this PR has done the following:
- [ ] Tests Added- [ ] Documentation Added- [ ] Name of contributors Added to AUTHORS.rstDescription of PR
Fixed unnecessary internal logging messages when aggregating recursively, see Issue #545
closes #545