-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove travis and appveyor CI config #409
Remove travis and appveyor CI config #409
Conversation
Could not review pull request. It may be too large, or contain no reviewable changes. |
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 35 35
Lines 4090 4090
=======================================
Hits 3814 3814
Misses 276 276 Continue to review full report at Codecov.
|
@gidden, can you check whether there are any other files or settings that can be removed as part of the migration to GitHub Actions and codecov? thanks! |
@znicholls - this would remove files required for the I think we have three options:
I would prefer 1 or 3, as otherwise things will get out of sync. Other preferences? |
Having done this a few times now (see eg github.com/openscm/scmdata or github.com/openscm/openscm-twolayermodel), I’d go for 1. The ultimate source of truth is the CI. The Makefile is a pure convenience but I don’t think you or @danielhuppmann use it so there’s no point keeping it. If I get back into serious development I’ll add it back in but there’s no point having it unless it’s useful. |
thanks @gidden & @znicholls for the input! |
just realized that I'm actually using |
f014d98
to
2bebc3b
Compare
re-added the environment files needed by |
https://github.com/danielhuppmann/pyam/pull/16/files fixes up the |
thanks @znicholls for the assist! |
Please confirm that this PR has done the following:
Description of PR
This PR: