Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove travis and appveyor CI config #409

Merged

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Jun 27, 2020

Please confirm that this PR has done the following:

  • Description in RELEASE_NOTES.md Added

Description of PR

This PR:

  • Removes the configuration files for travis and appveyor.
  • Badges on the docs pages have been updated (see latest on RTD).
  • integration with travis and appveyor has been deactivated.

@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@codecov
Copy link

codecov bot commented Jun 27, 2020

Codecov Report

Merging #409 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #409   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files          35       35           
  Lines        4090     4090           
=======================================
  Hits         3814     3814           
  Misses        276      276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac9708...c89696d. Read the comment docs.

@danielhuppmann danielhuppmann marked this pull request as ready for review June 27, 2020 11:10
@danielhuppmann danielhuppmann requested a review from gidden June 27, 2020 11:10
@danielhuppmann
Copy link
Member Author

@gidden, can you check whether there are any other files or settings that can be removed as part of the migration to GitHub Actions and codecov? thanks!

@gidden
Copy link
Member

gidden commented Jul 1, 2020

@znicholls - this would remove files required for the make commands (namely environment files). we were using make test etc on our various CIs, but now this is not needed for github actions.

I think we have three options:

  1. remove also the Makefile on which this depends
  2. keep the environment files
  3. use make in the github actions

I would prefer 1 or 3, as otherwise things will get out of sync. Other preferences?

@znicholls
Copy link
Collaborator

znicholls commented Jul 1, 2020

Having done this a few times now (see eg github.com/openscm/scmdata or github.com/openscm/openscm-twolayermodel), I’d go for 1. The ultimate source of truth is the CI. The Makefile is a pure convenience but I don’t think you or @danielhuppmann use it so there’s no point keeping it. If I get back into serious development I’ll add it back in but there’s no point having it unless it’s useful.

@danielhuppmann
Copy link
Member Author

thanks @gidden & @znicholls for the input!

@danielhuppmann
Copy link
Member Author

just realized that I'm actually using make publish-on-pypi for every release...

@danielhuppmann
Copy link
Member Author

re-added the environment files needed by make

@znicholls
Copy link
Collaborator

https://github.com/danielhuppmann/pyam/pull/16/files fixes up the Makefile so you can remove the ci directory again

@danielhuppmann
Copy link
Member Author

thanks @znicholls for the assist!

@danielhuppmann danielhuppmann merged commit 0d5bc4a into IAMconsortium:master Jul 2, 2020
@danielhuppmann danielhuppmann deleted the devops/remove-ci branch July 2, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants