Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up of Excel-io utils #382

Merged
merged 11 commits into from
Jun 3, 2020

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented May 25, 2020

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Description in RELEASE_NOTES.md Added

Description of PR

While trying to get pyam to work with Python 3.8, I stumbled over a few loose inconsistencies. This PR removes explicit ExcelWriter dependencies and let's this be handled by pandas internally.

It also cleans up a few docstrings formatting issues.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 86.036% when pulling b738ace on danielhuppmann:io/xlsx into ef2f69a on IAMconsortium:master.

@coveralls
Copy link

coveralls commented May 25, 2020

Coverage Status

Coverage decreased (-0.3%) to 86.042% when pulling 173c92b on danielhuppmann:io/xlsx into 2101cfe on IAMconsortium:master.

@danielhuppmann danielhuppmann marked this pull request as ready for review May 25, 2020 15:49
@danielhuppmann danielhuppmann requested a review from gidden May 25, 2020 15:49
@danielhuppmann danielhuppmann removed the request for review from gidden June 3, 2020 05:40
@danielhuppmann danielhuppmann merged commit fbee76d into IAMconsortium:master Jun 3, 2020
@danielhuppmann danielhuppmann deleted the io/xlsx branch June 3, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants