Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for interpolation with extra columns #352

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Mar 24, 2020

Please confirm that this PR has done the following:

  • Tests Added
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR fixes the issue raised by @Rlamboll in #351: the interpolate() function now does not return 'data' with nan when having an IamDataFrame with extra columns.

Data with non-matching values in extra columns are treated as separate timeseries - see the new test test_interpolate_extra_cols.

closes #351

@coveralls
Copy link

coveralls commented Mar 24, 2020

Coverage Status

Coverage decreased (-0.2%) to 85.564% when pulling 86afc2f on danielhuppmann:feature/interpolate_extracols into f5cba2a on IAMconsortium:master.

@danielhuppmann danielhuppmann marked this pull request as ready for review March 24, 2020 13:48
@danielhuppmann danielhuppmann requested a review from Rlamboll March 24, 2020 13:48
@danielhuppmann danielhuppmann changed the title bugfix for interpolation with extracts bugfix for interpolation with extra columns Mar 24, 2020
Copy link
Collaborator

@Rlamboll Rlamboll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a fix!

@danielhuppmann
Copy link
Member Author

merging as approved by @Rlamboll

@danielhuppmann danielhuppmann merged commit 0d2451c into IAMconsortium:master Mar 24, 2020
@danielhuppmann danielhuppmann deleted the feature/interpolate_extracols branch March 24, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nans in additional columns
3 participants