-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning level to DataValidator #431
Add warning level to DataValidator #431
Conversation
After discussion in weekly stand-up, will change the fail message start for the warning case, as it might be confusing to refer to a "failed" validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - a few suggestions inline, then good to be merged from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As just discussed bilaterally, I'd suggest a few changes detailed inline below.
Seems like I can't respond to the comment by @phackstock on the warning-level inline, so putting this here. I think that the suggestion to use integers instead of strings is just confusing to non-expert users, without adding any practical benefit. In yesterday's ScenarioCompass meeting, we discussed the need for different types of warnings in the sense of "warning for deviation from historical energy data" versus a "biodiversity concern in the future". Here, there is no clear ordering in terms of low/medium/high - instead, this could be clearly differentiated using colors. Going one step further, it may be useful to define the allowed warning-level-names in the nomenclature.yaml project-config, not the package, so that we don't have to always make a new release when adding new levels. |
As discussed in our meeting, incorporating the following features now:
Follow-up PRs will include:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good as a first step!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to be merged from my side.
Closes #426
Adds a
warning_level
attribute to data validation YAML files and registers warnings in log, as specified in #426.If present, failed validation does not raise errors for corresponding criteria.