Remove dimensions implicit default from DataStructureDefinition
#422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimensions implicit defaultdimensions implicit default from DataStructureDefinition
danielhuppmann
approved these changes
Nov 13, 2024
| * Each "dimension" to be used for validation (default: *variable* and *region*) must | ||
| have its own sub-directory in the *definitions* folder. The dimension names usually | ||
| follow the column names of the IAMC data format. | ||
| * Each "dimension" to be used for validation must have its own sub-directory in |
There was a problem hiding this comment.
Is this still true? So if we only import variables from an external repo, do we need a definitions/variable folder?
There was a problem hiding this comment.
I was wondering how to rewrite this clearly and succinctly. With this PR, if dimensions are imported from external repos, it's only necessary to specify the subfolders if no dimensions are specified in nomenclature.yaml.
phackstock
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes implicit default dimensions
["region", "variable"]fromDataStructureDefinition, instead defaulting todefinitionssubdirectories.Running workflows without
definitionssubdirectories is also possible as long asnomenclature.yamlsets the dimensions and respective external repos (seetest_mapping_from_external_repository's configuration file).For project validation,
dimensionsdefaults to either those innomenclature.yamlor todefinitionssubdirectories (without either, it fails).