Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tc-portal euid add phone number #97

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

ssundahlTTD
Copy link
Contributor

Add the ability to opt out by phone number for EUID.

image

image

@ashleysmithTTD
Copy link
Contributor

There's a couple places in the text from your screenshot where it says "email" or "email address" but you have phone number selected. it looks like for the uid2 page, the text doesn't change by what's selected, just make it "email or phone"

@ashleysmithTTD
Copy link
Contributor

The spacing near the Next button is off now, can you increase the margin so the text isn't as close to the button

@ashleysmithTTD
Copy link
Contributor

ashleysmithTTD commented Nov 22, 2024

When I enter a phone number without the country code, it errors and says 'please enter a phone number' without telling me it was the country code and defaults back to email address being selected. I think it should at least keep phone number selected (this needs to be fixed for uid2 and euid). this happens for any invalid phone number entry where it goes back to email address being selected

@ssundahlTTD ssundahlTTD merged commit 4348190 into main Nov 22, 2024
3 checks passed
@ssundahlTTD ssundahlTTD deleted the sas-UID2-4428-tc-portal-euid-add-phone-number branch November 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants