Clarify time spent in data generation #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simple mean of the percentage of time taken in data generation can be misleading: "1-100 ms, ~50% in data generation" can mean: - generation always takes 1ms, rest of the test takes 0-99 ms - generation takes 1-50 ms, rest of the test takes 1-50 ms Specifying a range the same way as the runtime prvents confusing these cases.
|
See issue #3598 |
|
Tests are failing in https://github.com/andreareina/hypothesis/blob/data-generation-runtime/hypothesis-python/tests/cover/test_statistical_events.py#L163-L168. The "0%" case maps cleanly onto "< 1ms", but the "50%" and "100%" cases aren't as clean. On my machine the generation consistently takes 49ms, but I could imagine that other machines might take 50, 51ms or even a range. |
|
Writing tests for |
e5cbb6f to
3c0ec72
Compare
Zac-HD
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple mean of the percentage of time taken in data generation can be misleading: "1-100 ms, ~50% in data generation" can mean:
Specifying a range the same way as the runtime prevents confusing these cases.
Fixes #3598.