[O] General optimizations

HyDevelop · Dec 24, 2019 · c8d0982 · c8d0982
1 parent a0edbcf
commit c8d0982
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/main/java/cc/moecraft/icq/user/GroupManager.java b/src/main/java/cc/moecraft/icq/user/GroupManager.java
@@ -29,11 +29,10 @@ public class GroupManager
      */
     public Group getGroupFromID(long id)
     {
-        if (groupCache.containsKey(id))
+        if (!groupCache.containsKey(id))
         {
-            return groupCache.get(id);
+            groupCache.put(id, new Group(bot, id));
         }
-        groupCache.put(id, new Group(bot, id));
-        return getGroupFromID(id);
+        return groupCache.get(id);
     }
 }
diff --git a/src/main/java/cc/moecraft/icq/user/UserManager.java b/src/main/java/cc/moecraft/icq/user/UserManager.java
@@ -29,11 +29,10 @@ public class UserManager
      */
     public User getUserFromID(long id)
     {
-        if (userCache.containsKey(id))
+        if (!userCache.containsKey(id))
         {
-            return userCache.get(id);
+            userCache.put(id, new User(bot, id));
         }
-        userCache.put(id, new User(bot, id));
-        return getUserFromID(id);
+        return userCache.get(id);
     }
 }