Add options to shift pie chart around #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `horizontalShift` and `verticalShift` options for pie charts. These options accept either a number (in px), or a `px` or `%` string. Numbers or `px` strings shift right for positive numbers, left for negatives. `%` strings are converted to a `px` value equal to the percentage of the width or height. Once values are in `px`, negative values shift the chart to the top/left; positive values shift the chart to the bottom/right. The radius calculation has been updated to account for the shift. It computes the maximum radius possible which would not cause the chart to exceed the boundaries, then applies the sizeRatio to further scale the chart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
horizontalShiftandverticalShiftoptions for pie charts.These options accept either a number (in
px), or apxor%string.Numbers or
pxstrings shift right for positive numbers, left fornegatives.
%strings are converted to apxvalue equal to the percentage of thewidth or height.
Once values are in
px, negative values shift the chart to the top/left;positive values shift the chart to the bottom/right.
The
radiuscalculation has been updated to account for the shift. Itcomputes the maximum radius possible which would not cause the chart to
exceed the boundaries, then applies the
sizeRatioto further scale thechart.
Further improvements could be made in drying up the code a little, but the
function is all there.