Fix coverage issue in BC tests #830
Conversation
… choices smaller, also suppress the warning about too large number of choices.
32dbce2 to
293015c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #830 +/- ##
==========================================
+ Coverage 95.66% 95.69% +0.03%
==========================================
Files 102 102
Lines 9655 9650 -5
==========================================
- Hits 9236 9235 -1
+ Misses 419 415 -4 ☔ View full report in Codecov by Sentry. |
| @hypothesis.settings( | ||
| deadline=20000, | ||
| max_examples=15, | ||
| # TODO: one day consider removing this. For now we are good. |
There was a problem hiding this comment.
maybe this is obvious for someone who's more familiar with hypothesis or this codebase but what does this check do? would it be helpful to clarify when it would be possible to remove this check or what's going that causes this check to fail?
There was a problem hiding this comment.
Thanks that is a good point! I added a better description. Does it make sense now @tomtseng ?
|
Ok so we still have spurious coverage issues. @AdamGleave would you merge this and we see if they persist on master? |
|
I'll merge this @ernestum but the issue with test coverage appears to be in |
Some missing coverage in BC testing was surfacing in a couple of the most recent PRs. This PR fixes it so we don't have to ask @AdamGleave to merge all the time.