Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes some typing issues that arose on a fresh install:
preference_comparison.py
:imitation/src/imitation/algorithms/preference_comparisons.py
Line 773 in 944edce
var_estimate
is defined in the previous code branches, except one, which callsraise_uncertainty_on_not_supported
which raises an error, and this requires an explicit type annotation to indicate thatThis is a very small PR, so I can add more typing fixes where I notice them to add some more substance, if desired.
Testing
ci/code_checks.sh
, which failed on a fresh install, now passes