Empty transform matrix causing reference errors #6495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Merging. |
Exairnous
added a commit
that referenced
this pull request
Sep 24, 2024
Fixes #6496 Chromium version 128 introduced a bug in Hubs that was fixed by #6495 but PR#6495 seems to have introduced the bug detailed in issue#6496 for all browsers. Now Chromium has fixed an issue on their end as detailed here: https://issues.chromium.org/issues/361823993 which should fix the original bug that PR#6495 addressed in Hubs, which allows us to revert the fix on the Hubs side (PR#6495) and so fix the issue#6496 bug. However, this doesn't do anything for the potentially deeper issues in the system that were possibly exposed with PR#6495.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent update to Chrome (128) appears to have exposed a bug, as described in this Discord post.
I traced at least one cause (there may be more) to the use of a temporary array in the hoverable-visuals component. A threejs matrix is copied into the array and then the position elements are read and ultimately submitted as uniforms to the WebGL shader. However, if
interactorOneorinteractorTwoare not active, the matrix is not written and the required elements are never initialized. Seeding the array with a unit matrix fixes the problem.It's not clear why this has only just started causing a runtime issue. Perhaps Chrome used to interpret
undefinedas zero instead of throwing a TypeError?