Fix Gizmo Issues #90
Merged
Fix Gizmo Issues #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the performance isn't ideal.
Removed debug prints. Removed commented code. Removed one piece of boilerplate. Removed one unused import.
…n add-on registration.
keianhzo
approved these changes
Jul 25, 2022
|
BTW I just realized that the related issues haven't closed after merging this. I will close them manually. For future reference if you want to close them as a result of merging the PR you have to put https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix all the issues with gizmos, plus improve the performance and prevent any performance drain on scenes that aren't using gizmos. I feel it also simplifies the logic in some places. Objects are now linked directly with gizmos for fast lookups and shouldn't become stale because the system is re-initialized on any change, this also means that there is no further use of a dedicated remove gizmo function, so it has been removed. Blender's msgbus system has been employed to trigger a refresh when a gizmo object is renamed (unfortunately bones seem to be too unstable to be subscribed to directly, so a refresh is triggered on any bone rename)
This PR fixes issues:
#83
#84
#85
#86
#87