Operator to automatically bake lightmaps for selected objects. #281
Conversation
There was a problem hiding this comment.
Thank you for the PR and apologies for the delay in reviewing it. I think it will provide some good functionality, but I think it's scope should be modified slightly. I think your PR is great for baking light maps for objects that don't have them yet, but your PR doesn't address all the intricacies that can arise when attempting to rebake already set up light maps. PR #48 does this very well and has a lot of error checking already in place, so I'm thinking it makes the more sense to have your PR to bake an initial light map for objects and let the other PR handle any rebaking.
With that in mind, I'm thinking that a check should be added to this PR to avoid baking light maps when they are already present on an object.
PR #48 also adds a panel in the render settings, so I'm thinking that maybe it would be better to add the operator there once that's in, rather than to a new panel in the object properties.
I believe calling bake via execute instead of invoke causes the UI to block with no feedback to the user. I think it would be better to use the non-blocking version and reset all the settings after the bake has completed via a handler (like what is done with reflection probes). The overridden settings can be stored and restored as with reflection probes in reflection_probe.py lines 362-379 and lines 334-337
bpy.app.handlers.object_bake_complete is probably the needed handler.
At some point in the Blender 4 series linear was separated out into a bunch of different versions, Linear Rec.709 is what we have used when importing HDRs and seems to be the new default. This code should make it work for all Blender versions Co-authored-by: Exairnous <mythologylover75@gmail.com>
…y the auto baker.
|
I have created this addon with PR #48 in mind. |
| new_filepath = f"//{node.image.name}.hdr" | ||
| node.image.packed_files[0].filepath = new_filepath | ||
| node.image.filepath_raw = new_filepath | ||
| node.image.filepath = new_filepath |
There was a problem hiding this comment.
I tested those four lines in my own script on blender 4.2.1, it doesn't seem to be needed if you want to unpack the textures later, the names are correct in the textures folder as far as I can tell, and actually those lines gave me an error during the execution saying the file didn't exist. I didn't test your PR though, so may not apply, but that's something to verify.
…g, uses the space better for multiple objects and materials but is prone to overlaps in some corner cases.
| for ob in obj_list: | ||
| for slot in ob.material_slots: | ||
| if slot.material is not None: | ||
| objs_to_uv_unwrap.extend(material_object_associations[slot.material]) |
There was a problem hiding this comment.
If I'm not mistaken, you may end up having an object several times in objs_to_uv_unwrap. You probably want to use a set and use objs_to_uv_unwrap.update here.
…rectly now. The UV map in the last slow now gets the correct name as well
Added an operator that bakes lightmaps using Cycles for all selected objects that have at least one material. It uses UV slot 1 for the lightmap and creates the slot if not present already. It also automatically creates the required MOZ_Lightmap nodes and wires them correctly. If a MOZ_Lightmap node is present, the addon assumes that the user has taken care of the correct setup and bakes directly.
Baking happens using the Cycles render engine. The created lightmaps are saved as .hdr to Blender's temporary directory, packed and then removed to keep the user's system clean.
The new operator can be found in the Object Properties Editor in a new Panel "Hubs Lightmap Baker"