Fix for gtlf exporter python library path changes #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exairnous
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
LGTM.
I did some checking on that format variable we were talking about at the add-on meeting and I found the commit + PR where it was removed. It looks like that variable always evaluated to 'gltf_format' so if you wanted to just use that string I think it would be fine, but I'll leave it up to you :)
Commit + PR where it was removed:
KhronosGroup/glTF-Blender-IO@e63bb38
KhronosGroup/glTF-Blender-IO#1832
|
@Exairnous I took your advice and simplified that change. |
|
Thanks for this fix! |
|
@rawnsley Ah, nice! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #225 in Blender 3.6 by fixing some of the import paths. I'm not sure of the implications for previous versions of Blender though or if there are any other compatibility issues, so I will keep this in draft for now.