Fix error when clearing the srcNode property in audio and video texture target components. #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re target components. Clearing the srcNode property triggers a reset of the bone EnumProperty, but this failed because of an unguarded check for the mode of the srcNode object when accessing the bone EnumProperty to reset it. Add a check for whether the srcNode has an object before checking whether the srcNode object is in edit mode so that resetting the bone EnumProperty to the blank id doesn't cause an error when getting the list of bones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearing the srcNode property triggers a reset of the bone EnumProperty, but this failed because of an unguarded check for the mode of the srcNode object when accessing the bone EnumProperty to reset it. This PR adds a check for whether the srcNode has an object before checking whether the srcNode object is in edit mode so that resetting the bone EnumProperty to the blank id doesn't cause an error when getting the list of bones.