Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos, improve docs, and remove trailing periods. #117

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

Exairnous
Copy link
Contributor

Fixed typos and grammar errors.
Added the full (mozilla.org) default URL to the video component (it was just https://). Improved the descriptions/tooltips to better document what the things do. Removed the trailing periods from descriptions/tooltips as Blender provides them for us and will cause duplicates if we provide them too. Periods aren't provided for labels, so those have been left.

Fixed typos and grammar errors.
Added the full (mozilla.org) default URL to the video component (it was just https://).
Improved the descriptions/tooltips to better document what the things do.
Removed the trailing periods from descriptions/tooltips as Blender provides them for us
and will cause duplicates if we provide them too. Periods aren't provided for labels,
so those have been left.
@keianhzo keianhzo self-requested a review September 14, 2022 09:39
@sarhugo
Copy link
Contributor

sarhugo commented Sep 14, 2022

Maybe here is a place to fix this? #77

@Exairnous
Copy link
Contributor Author

@sarhugo Yup, Thank you! That should definitely be in here!

@Exairnous
Copy link
Contributor Author

Actually, I may have spoken too soon, this could be a little tricky because not just the display name and tooltip is misspelled. I think the Hubs client would have to be modified to accept the new spelling for the component name as well, plus we'll need to provide a migration for old blend files. All that to say that it's probably too big for this PR, unless we want to keep the component name and just fix the display name and tooltip. @keianhzo What are your thoughts on this, should we wait and do everything in a new PR or should I add in a fix for the display stuff only and we can address the component name (or not) later?

@keianhzo
Copy link
Contributor

Not super concerned about the misspelled frustrum component name as long as the user facing text is correct so I'm ok with just fixing that for now.

Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keianhzo keianhzo merged commit 8306900 into Hubs-Foundation:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants