Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startOffset and timeScale to loop-animation #109

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

netpro2k
Copy link
Contributor

@netpro2k netpro2k commented Sep 1, 2022

Adds startOffset (skip this many seconds on the first loop of the animation) and timeScale (scale the animation playback speed by this factor) to the "loop-animation" component. Note in the blender UI startOffset will be displayed in frames, converted to seconds at export based on the scene's FPS settings.

Also removed "paused" as it doesn't actually work, and doesn't make much sense given the lack of any way to actually start the animation programmatically if it did work...

Requires Hub change Hubs-Foundation/hubs#5692

@netpro2k netpro2k requested a review from keianhzo September 1, 2022 03:05
@Exairnous
Copy link
Contributor

Does "paused" not work with Trigger Volume? I am hoping to add Trigger Volume to the exporter in the nearish future.

Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keianhzo
Copy link
Contributor

keianhzo commented Sep 6, 2022

Does "paused" not work with Trigger Volume? I am hoping to add Trigger Volume to the exporter in the nearish future.

Not sure if we want to add volume trigger support in the Blender Add-on so I think removing paused is ok for now.

@keianhzo keianhzo merged commit b9bf191 into master Sep 6, 2022
@netpro2k
Copy link
Contributor Author

netpro2k commented Sep 6, 2022

Woops should have marked this as a draft. Still waiting for some test scenes to actually try it in Hubs. I suspect it will be fine though.

@Exairnous
Copy link
Contributor

Exairnous commented Sep 8, 2022

Does "paused" not work with Trigger Volume? I am hoping to add Trigger Volume to the exporter in the nearish future.

Not sure if we want to add volume trigger support in the Blender Add-on so I think removing paused is ok for now.

I have had several requests from artists for it to be supported so I was planning to open a PR for it soon after the add-on was out of beta. And my view has always been that if it works and is useful, then we should support it

@netpro2k
Copy link
Contributor Author

netpro2k commented Sep 8, 2022

We certainly want some form of trigger volume thing, but the current thing that exists was a total experiment and is not really supported in its current form ( I suspect its also broken in all sorts of ways). I don't think we should bother adding it to the addon in its current form since that just adds more work whenever we do come up with the "real" thing.

@Exairnous
Copy link
Contributor

Yeah, I understand it's not really supported and will be eventually replaced with a better version, but as long as it works to some degree and is useful to artists, and until it's actually removed I think it should be added to the add-on, otherwise people are still going to have juggle scenes between the add-on and Spoke. With the current architecture, it's really not difficult to support and when the time comes it can just be deleted and replaced with the "real" thing. I'm happy to make this my pet project and assume responsibility for it.

However, if everyone is really against having it in the main add-on, perhaps a repo of experimental definitions could be created by the Hubs team and it could live there and people could then download it and add it to their local copy of the add-on if they wish? As a sort of middle ground?

@netpro2k
Copy link
Contributor Author

netpro2k commented Sep 9, 2022

One of the things we wanted with the new addon architecture was the ability for people to be able to specify a folder/folders for their own components. This is how we would want third party devs to work with their own components.

@Exairnous
Copy link
Contributor

So, are you saying that you would prefer my "middle ground" proposal, but want to wait until the external definition loading is present?

@Exairnous
Copy link
Contributor

Another thing that just occurred to me about having the paused property on loop animation is that I've been thinking for awhile now that it would be really cool to be able to toggle an avatar's animations on/off with a keyboard shortcut, so if that ever gets implemented then we'd want the paused property. Obviously this doesn't affect anything currently, but it was on my mind, so I thought I'd mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants