Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Kanban setup #21

Open
dvcorreia1984 opened this issue Aug 7, 2023 · 3 comments
Open

Review Kanban setup #21

dvcorreia1984 opened this issue Aug 7, 2023 · 3 comments

Comments

@dvcorreia1984
Copy link
Collaborator

In this review were are cheking that the Kanban board has been setup correctly:

Link to project: https://github.com/Hsuwaddyhtat22/Pokemon-Capstone-JS/projects/1

Team members: 2

@Olamarx
Copy link

Olamarx commented Aug 8, 2023

Hi Team,

Good job so far, indeed you have spent time on this project!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • Use of Kanban board ✔️
  • Task assignation ✔️

Required Changes ♻️

Check the comments under the review.

  • I notice your "set up kanban" card does not have time attached, kindly add it.
  • I also noticed the whole cards total 16, kindly note that since you are two, the cards are to be two in number.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@dvcorreia1984
Copy link
Collaborator Author

Hi @Olamarx.

Thank you for your feedback. I removed the setup of Kanban board, as this was a issue I created and not part of the project import cards.

I dont understand you comment "the cards have to be two in number". Can you please elaborate on this comment?

Regards. Victor & @Hsuwaddyhtat22

@TedLivist
Copy link

STATUS: APPROVED ✔️ ✔️

Hi @dvcorreia1984 and @Hsuwaddyhtat22,

✔️ Tasks are complete and well assigned

Your project is complete! There is nothing else to say other than... it's time to go ahead with the project :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants