yasm: fix segfaults GNU assembler

[denji]

Fix yasm segfaults GNU assembler files on OS X.
Bug: http://tortall.lighthouseapp.com/projects/78676/tickets/269

brew reinstal https://raw.github.com/Homebrew/homebrew/70a3bb/Library/Formula/yasm.rb

[adamv]

Is there an example of an ASM file that causes a segfault that we can use as a test?

[denji]

@adamv

/usr/local/bin/yasm -f macho64 -X gnu -p gas --prefix=_ crypto/keccak/KeccakF-1600-x86-64-gas_yasm.s -o crypto/keccak/KeccakF-1600-x86-64-gas_yasm.o
make: *** [crypto/keccak/KeccakF-1600-x86-64-gas_yasm.o] Segmentation fault: 11

You accept the patch is or will continue to watch on segfaults?

[denji]

/cc @moinakg

[adamv]

There's at least one more GAS related ticket, going back 3 years: http://tortall.lighthouseapp.com/projects/78676/tickets/147-gas-parser-is-not-recognize-a-lot-of-keywords-used-for-macroses

[moinakg]

FYI, this patch does not provide support for all Gas 2.x features but fixes
some basic breakages. For example ability to use ".equ" to define arbitrary
textual labels (like C macros) is not present. Only expressions are
supported.

However fixing a couple of basic bugs is a start.
On 20 May 2014 20:18, "Adam Vandenberg" notifications@github.com wrote:

There's at least one more GAS related ticket, going back 3 years:
http://tortall.lighthouseapp.com/projects/78676/tickets/147-gas-parser-is-not-recognize-a-lot-of-keywords-used-for-macroses

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/29388#issuecomment-43635739
.

[adamv]

We're not going to start carrying partial patches for this issue. Please work with upstream to get patches merged into the official distribution.