-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python@3.9: update upstream patch #66063
Conversation
Testing now that Homebrew/brew#9373 is merged |
While this patch works for building Python itself, pip packages depending on I strongly suspect Python was simply unprepared from going from 10 to 11...
|
Currently looking at what is going on in: |
NVM, that is a wheel issue. |
Actually - it is a distutils problem as wheel imports distutils, and I believe I found the culprit:
That file is automatically generated at build time and changing the buildconfig such that |
@fxcoudert So that this works across different versions of MacOS, the complete solution would be: if MacOS.version >= :big_sur
args << "MACOSX_DEPLOYMENT_TARGET=11.0.1"
else
args << "MACOSX_DEPLOYMENT_TARGET=#{MacOS.version}"
end And that's it! Everything including pip just works that way. For some reason, MacOs.verion simply evaluates to |
Reminder to myself: when I merge this, I need to open yet another python update PR, this time to update wheel which was released in the meantime. 😢 |
Turns out there is another bug with
MACOSX_DEPLOYMENT_TARGET
being an integer in Python. Updating to the latest version of the upstream patch. This is bad, because it will hit all formulas based on Python, on Big Sur 11.0.1 (but not the 11.1 beta).