Python 3.9.1 bigsur #65793

jackbm633 · 2020-11-27T15:49:01Z

[*] Have you followed the guidelines for contributing?
[*] Have you checked that there aren't other open pull requests for the same formula update/change?
[*] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting? - Having some issues with this - says I need to have latest python 3.9 version.
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)? - Yes, once the Python 3.9.1 upstream version is released

Hi everyone - this is my first contribution to Homebrew so please forgive me if I make any mistakes along the way. I've been in the process of testing Brew packages on my M1 MacBook Pro, and Python 3.9 currently doesn't work. 3.9.1 is going to be the first version of Python that will support M1 out of the box, but changing the existing formula to the 3.9.1 RC doesn't work
because Python expects a MacOS version number 10.x whereas Big Sur reports 11.x. Therefore, I have set the environment variable SYSTEM_VERSION_COMPAT to 1 and then got the version of macOS using sw_vers, which will report 10.16: Python is happy with that. This avoids the following error, which I get with both 3.9.0 and 3.9.1:

Last 15 lines from /Users/jbeckitt/Library/Logs/Homebrew/python@3.9/02.make:
    self.run_command(cmd_name)
  File "/private/tmp/python@3.9-20201127-62347-16hz8ht/Python-3.9.1rc1/Lib/distutils/cmd.py", line 313, in run_command
    self.distribution.run_command(command)
  File "/private/tmp/python@3.9-20201127-62347-16hz8ht/Python-3.9.1rc1/Lib/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/private/tmp/python@3.9-20201127-62347-16hz8ht/Python-3.9.1rc1/Lib/distutils/command/build_ext.py", line 340, in run
    self.build_extensions()
  File "/private/tmp/python@3.9-20201127-62347-16hz8ht/Python-3.9.1rc1/./setup.py", line 447, in build_extensions
    self.detect_modules()
  File "/private/tmp/python@3.9-20201127-62347-16hz8ht/Python-3.9.1rc1/./setup.py", line 1784, in detect_modules
    self.detect_readline_curses()
  File "/private/tmp/python@3.9-20201127-62347-16hz8ht/Python-3.9.1rc1/./setup.py", line 1015, in detect_readline_curses
    (tuple(int(n) for n in dep_target.split('.')[0:2])
AttributeError: 'int' object has no attribute 'split'

This reverts commit 82b31a2.

…lity fix"" This reverts commit aec909b.

fxcoudert · 2020-11-27T16:15:08Z

sw_vers, which will report 10.16

No, that's not what happens for me on macOS 11.1, and that would be a bug if it did.

Python expects a MacOS version number 10.x whereas Big Sur reports 11.x

That needs to be reported and fixed, not hacked by pretending we're on another version. Also: so far we haven't seen a problem with that, so far.

fxcoudert · 2020-11-27T16:15:23Z

Formula/python@3.9.rb

-    sha256 "9ad938e5803a6c8ce6fb183f479968cadc1d6b6cb75dd7a11d4761c5e3635131" => :big_sur
-    sha256 "a39639719e49bf3631ef41705267eae5ae06b78aebc0e8c3ffd9fdb91e75d56c" => :catalina
-    sha256 "4462c76fea0dc7abb9ea959d82594aa0b10191f5bc3e43d8d44131a05bee3950" => :mojave
+    sha256 "bd4ebe03f4c8371c87b2e2db46d5a8ebe0d3f2940f64d8228b901048f1dd9290" => :big_sur


Do not alter bottle blocks

fxcoudert · 2020-11-27T16:15:57Z

Formula/python@3.9.rb

@@ -305,9 +305,9 @@ def sitecustomize
          # site_packages; prefer the shorter paths
          long_prefix = re.compile(r'#{rack}/[0-9\._abrc]+/Frameworks/Python\.framework/Versions/#{xy}/lib/python#{xy}/site-packages')
          sys.path = [long_prefix.sub('#{HOMEBREW_PREFIX/"lib/python#{xy}/site-packages"}', p) for p in sys.path]
-          # Set the sys.executable to use the opt_prefix. Only do this if PYTHONEXECUTABLE is not


Do not alter this

fxcoudert · 2020-11-27T16:16:04Z

Formula/python@3.9.rb

@@ -321,20 +321,16 @@ def caveats
    <<~EOS
      Python has been installed as
        #{HOMEBREW_PREFIX}/bin/python3
-


Do not alter whitespace

jackbm633 · 2020-11-27T16:30:38Z

Okay @fxcoudert , I see what you mean. So is it an issue on my end do you reckon - something wrong with my system configuration?

fxcoudert · 2020-11-27T16:32:26Z

So is it an issue on my end do you reckon - something wrong with my system configuration?

I don't know, that's why it would be good to test so it can get fixed before an actual release

jackbm633 · 2020-11-27T16:38:17Z

So is it an issue on my end do you reckon - something wrong with my system configuration?

I don't know, that's why it would be good to test so it can get fixed before an actual release

Just completely removed Homebrew from my system and trying with a clean installation 👍 - I will report back with results!

jackbm633 · 2020-11-27T16:45:51Z

I'm closing this - it definitely is an issue on my end 😨. My brother who owns an M1 Mac mini compiled 3.9.0 fine with the default formula.

/sparkle Thanks @fxcoudert for your help - I'll continue with the testing effort on M1!

abarisain · 2020-11-27T22:14:28Z

FYI I ran into this issue today after wiping my Mac, and I didn't before.

I ran 11.1 beta when it was successful, and 11.0.1 when it failed.
By editing the formula and setting "MACOSX_DEPLOYMENT_TARGET=11.1", 11.0, 11.0.1 or 11.1.0, the formula works.
As soon as I set it back to #{MacOS.version}, boom, it breaks since it's "11"

I haven't looked into it more, not sure what the root cause is. Probably an upstream issue that homebrew might not want to fix.
Or we could special case 11.0 as the problem goes away with 11.1?

nisanthchunduru · 2020-12-01T00:12:41Z

Just sharing in case it helps anyone. After googling a bit, I was able to resolve the problem mentioned in the issue description by installing the XCode command line tools, updating Homebrew and then upgrading to the latest python@3.9 package

xcode-select --install
brew update
brew upgrade python@3.9

I'm not entirely sure why installed XCode command line tools resolved the problem. I'm just sharing in case it helps anyone.

fxcoudert · 2020-12-01T07:30:49Z

@nisanth074 @abarisain the issue is a python problem, reported in python/cpython#23556
I proposed a fix to the Python project, and we'll be including it in the next update, under testing now: https://github.com/Homebrew/homebrew-core/pull/65953/files

Fingel · 2020-12-01T22:50:34Z

Oddly, Ive been getting the following error since the patch was merged when trying to build any wheel:

File "/usr/local/Cellar/python@3.9/3.9.0_3/Frameworks/Python.framework/Versions/3.9/lib/python3.9/distutils/spawn.py", line 66, in spawn
        if _cfg_target_split > [int(x) for x in cur_target.split('.')]:
    AttributeError: 'int' object has no attribute 'split'

Is this unrelated? Maybe the same bug manifesting in distutils or something?

EDIT for anyone that finds this:

I was able to work around the wheel failing to build by setting the MACOSX_DEPLOYMENT_TARGET env var to '11.0', for example

MACOSX_DEPLOYMENT_TARGET='11.0' pip install MarkupSafe

Hopefully this is fixed upstream or wherever so this isn't something to worry about.

Jack Beckitt-Marshall and others added 3 commits November 27, 2020 15:35

Python 3.9.1 rc1 plus macOS Big Sur version compatibility fix

82b31a2

Revert "Python 3.9.1 rc1 plus macOS Big Sur version compatibility fix"

aec909b

This reverts commit 82b31a2.

Revert "Revert "Python 3.9.1 rc1 plus macOS Big Sur version compatibi…

fad4e22

…lity fix"" This reverts commit aec909b.

fxcoudert reviewed Nov 27, 2020

View reviewed changes

fxcoudert requested changes Nov 27, 2020

View reviewed changes

jackbm633 closed this Nov 27, 2020

jackbm633 deleted the python-3.9.1-bigsur branch November 27, 2020 16:46

BrewTestBot added the outdated PR was locked due to age label Jan 1, 2021

Homebrew locked as resolved and limited conversation to collaborators Jan 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python 3.9.1 bigsur #65793

Python 3.9.1 bigsur #65793

jackbm633 commented Nov 27, 2020

fxcoudert commented Nov 27, 2020

fxcoudert Nov 27, 2020

fxcoudert Nov 27, 2020

fxcoudert Nov 27, 2020

jackbm633 commented Nov 27, 2020

fxcoudert commented Nov 27, 2020

jackbm633 commented Nov 27, 2020

jackbm633 commented Nov 27, 2020

abarisain commented Nov 27, 2020 •

edited

Loading

nisanthchunduru commented Dec 1, 2020 •

edited

Loading

fxcoudert commented Dec 1, 2020

Fingel commented Dec 1, 2020 •

edited

Loading

Python 3.9.1 bigsur #65793

Python 3.9.1 bigsur #65793

Conversation

jackbm633 commented Nov 27, 2020

fxcoudert commented Nov 27, 2020

fxcoudert Nov 27, 2020

Choose a reason for hiding this comment

fxcoudert Nov 27, 2020

Choose a reason for hiding this comment

fxcoudert Nov 27, 2020

Choose a reason for hiding this comment

jackbm633 commented Nov 27, 2020

fxcoudert commented Nov 27, 2020

jackbm633 commented Nov 27, 2020

jackbm633 commented Nov 27, 2020

abarisain commented Nov 27, 2020 • edited Loading

nisanthchunduru commented Dec 1, 2020 • edited Loading

fxcoudert commented Dec 1, 2020

Fingel commented Dec 1, 2020 • edited Loading

abarisain commented Nov 27, 2020 •

edited

Loading

nisanthchunduru commented Dec 1, 2020 •

edited

Loading

Fingel commented Dec 1, 2020 •

edited

Loading