protobuf 3.14.0

[jeroen]

Created with brew bump-formula-pr.

resource blocks may require updates.

[jeroen]

The grpc linking error is unrelated to protobuf. This is because one of the dependencies of grpc has changed to c++17.
grpc problems solved in: #64943

[jeroen]

Rebased for the updated grpc...

[SMillerDev]

brew fetch --retry libphonenumber --build-bottle --force
brew install --verbose --build-bottle libphonenumber
brew test --retry --verbose torchvision

[jeroen]

We now see 2 errors in reverse dependencies which are unrelated protobuf. libphonenumber seems to have moved a tag:

==> Downloading https://github.com/google/libphonenumber/archive/v8.12.13.tar.gz
Error: SHA256 mismatch
Expected: 1d0dab61ab0d4ffa9d86fd93a46b0f4df7ab159bf8b8f08416dc211a753747b2
  Actual: 4d202b3d20c545d39a9a0bbaf0f7f26e64a8875429bfadf36f7015adb9bada37
 Archive: /Users/brew/Library/Caches/Homebrew/downloads/27743676f863120797162238737b4e922e38442c316df1848d20bb017ac70e7a--libphonenumber-8.12.13.tar.gz
To retry an incomplete download, remove the file above.
Already downloaded: /Users/brew/Library/Caches/Homebrew/downloads/27743676f863120797162238737b4e922e38442c316df1848d20bb017ac70e7a--libphonenumber-8.12.13.tar.gz

And it looks like libtorchvision has been compiled agains xQuartz (which is in /opt/X11) which is no longer available?

==> Testing torchvision
/usr/bin/sandbox-exec -f /private/tmp/homebrew20201117-3508-1m51uot.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/torchvision.rb --verbose --retry
==> /usr/bin/clang++ -std=c++14 main.cpp -o test -I/usr/local/opt/libtorch/include -I/usr/local/opt/libtorch/include/torch/csrc/api/include -L/usr/local/opt/libtorch/lib -ltorch -ltorch_cpu -lc10 -L/usr/local/Cellar/torchvision/0.8.1/lib -ltorchvision
==> ./test
dyld: Library not loaded: /opt/X11/lib/libpng16.16.dylib
  Referenced from: /usr/local/opt/torchvision/lib/libtorchvision.dylib
  Reason: image not found

Should I bump these as well, and rebuild again?

[SMillerDev]

For libphonenumber we should ask upstream if it was intentional, for torchvision we should figure out how to make it not do that. @gromgit might be able to help there.

[gromgit]

@jeroen, based on my local tests, torchvision just needs a depends_on "libpng" and a revision bump.

[jeroen]

@chenrui333 I think this is ready to merge. The only remaining error is:

==> FAILED
Error: 1 problem in 1 formula detected
libphonenumber:
  * stable sha256 changed without the url/version also changing; please create an issue upstream to rule out malicious circumstances and to find out why the file changed.

The upstream git repository doesn't have an issue tracker, but they seem to be creating and moving the latest tag as part of the release process to test release candidates.

[chenrui333]

yeah, let's move forward with the change.

[BrewTestBot]

@chenrui333 has triggered a merge.

[BrewTestBot]

⚠️ @chenrui333 bottle publish failed.

bottle publish failed

[chenrui333]

Auto-merging Formula/opencv.rb
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

[jeroen]

Is it because opencv was updated between when yesterday and now? So we need to rebump the revision, even one more?

[chenrui333]

yeah, that sounds about right, unfortunately. I just rebased and have another run before the merge.

[jeroen]

Hmm OK, I think the PR now no longer contains a bump to opencv, so it will probably fail for that...

[chenrui333]

Hmm OK, I think the PR now no longer contains a bump to opencv, so it will probably fail for that...

my bad

[chenrui333]

merged the cmake fix and rebased the PR. 🤞

[chenrui333]

rerun the build because 10.14 build somehow got skipped previously.

[chenrui333]

I will do the merge around lunch today.

[SMillerDev]

The upstream git repository doesn't have an issue tracker, but they seem to be creating and moving the latest tag as part of the release process to test release candidates.

Can you try and contact them regardless? Maybe tagging some maintainers here? The git manual says re-tagging is "the insane thing" to do and it just causes a lot of trouble for everyone.

[BrewTestBot]

@chenrui333 has triggered a merge.

[chenrui333]

Hi @rohininidhi or maybe @penmetsaa, 👋 we run into some libphonenumber audit check issue (since it got re-released?). Because there is no way for us to create an issue to track down on your side, I will tag you for clarifying the re-release is intentional for our better understanding the release process in general. Any feedback or comments are appreciated. Thanks!!

[BrewTestBot]

⚠️ @chenrui333 bottle publish failed.

bottle publish failed

[chenrui333]

curl: (35) OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to api.bintray.com:443

[BrewTestBot]

@chenrui333 has triggered a merge.

[chenrui333]

Thanks @jeroen!!

[jeroen]

Thanks for your help! I think this issue shows that there is some room for improvement in the homebrew build process.

Perhaps the CI could automatically bump the required bottles, such that the PR is not constantly outdated/blocked due to other things changing at the same time.