-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unbound 1.11.0 #58696
unbound 1.11.0 #58696
Conversation
The only failure for 10.14 and 10.13 was for The tests for 10.15 appear to have stalled. |
The We do need the 10.15 checks to run, though, in order to get updated bottles. The 10.15 runners have been having some trouble recently for some reason, but rerunning them usually does it. I'll retrigger it. If it doesn't work this time, try rebasing and force-pushing. |
Thank you @Rylan12, as always. |
Is there an upstream issue for this? |
On 10.15 and 10.13:
while on 10.14 only
So ok to merge I think. Thanks. |
@SMillerDev I believe it is because of the Cabal v1 install deprecation, and is therefore not an upstream issue? |
In that case someone should make a pull request to fix it. |
It sounds like @Bo98 is working on the @SMillerDev I understand not wanting to merge things that have had CI failures, but I think holding this up isn't doing anything positive. Are there other consequences I'm missing? |
I'm sure it won't hurt the progress there. But keeping this for another time like this isn't helping anything either. I think we need to be stricter in this and as a policy either have a pull request or an issue open. Currently we keep on rediscovering issues and it's hurting progress like here. TL;DR we need a PR or issue for |
I think that's a reasonable requirements to stick to. In this case, though, there is an issue open (#55253). |
#55253 isn't really an issue about |
But the reason Maybe that's not the case. If it's not, then there definitely should be an issue or PR for it. |
no
A quick temporary fix is to make it use "v1-install" directly (and no sandbox). "v2-install" requires either the MacPorts-style hack or wrapper scripts for every binary, both of which should have some A hybrid approach of v2-installing dependencies and not using Cabal for the actual I planned to discuss Cabal a bit at the next maintainer call, but I should probably not wait until then and figure something out this week. I should have dealt with it weeks ago since it's my fault really that the test fails. |
Agda issue reported in #58984 |
@Rylan12, @SMillerDev and @Bo98 I rebased and the only failure now is Thanks. |
Thanks, @miccal! |
Created with
brew bump-formula-pr
.