Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbound 1.11.0 #58696

Closed
wants to merge 1 commit into from
Closed

unbound 1.11.0 #58696

wants to merge 1 commit into from

Conversation

miccal
Copy link
Contributor

@miccal miccal commented Jul 27, 2020

Created with brew bump-formula-pr.

@miccal
Copy link
Contributor Author

miccal commented Jul 28, 2020

The only failure for 10.14 and 10.13 was for agda, which is to be expected.

The tests for 10.15 appear to have stalled.

@miccal miccal mentioned this pull request Jul 28, 2020
@Rylan12
Copy link
Member

Rylan12 commented Jul 28, 2020

The agda issue should be fine as it doesn't build from source anyway at the moment.

We do need the 10.15 checks to run, though, in order to get updated bottles. The 10.15 runners have been having some trouble recently for some reason, but rerunning them usually does it. I'll retrigger it. If it doesn't work this time, try rebasing and force-pushing.

@miccal
Copy link
Contributor Author

miccal commented Jul 28, 2020

Thank you @Rylan12, as always.

@SMillerDev
Copy link
Member

The agda issue should be fine as it doesn't build from source anyway at the moment.

Is there an upstream issue for this?

@miccal
Copy link
Contributor Author

miccal commented Jul 28, 2020

On 10.15 and 10.13:

Error: 2 failed steps!
brew test --verbose agda
brew test --verbose csound

while on 10.14 only adga failed.

csound is a known random failure.

So ok to merge I think.

Thanks.

@miccal
Copy link
Contributor Author

miccal commented Jul 28, 2020

Is there an upstream issue for this?

@SMillerDev I believe it is because of the Cabal v1 install deprecation, and is therefore not an upstream issue?

@SMillerDev
Copy link
Member

In that case someone should make a pull request to fix it.

@Rylan12
Copy link
Member

Rylan12 commented Jul 29, 2020

It sounds like @Bo98 is working on the agda issue. I'm not sure if it's: 1. going well or 2. will be done soon

@SMillerDev I understand not wanting to merge things that have had CI failures, but I think holding this up isn't doing anything positive. agda won't build regardless of this PR and I don't think merging this will make fixing agda it any easier/harder. Not merging only means we are holding back a new version of unbound for users (plus the ~171 formulae that depend on it in some way)

Are there other consequences I'm missing?

@SMillerDev
Copy link
Member

I'm sure it won't hurt the progress there. But keeping this for another time like this isn't helping anything either. I think we need to be stricter in this and as a policy either have a pull request or an issue open. Currently we keep on rediscovering issues and it's hurting progress like here.

TL;DR we need a PR or issue for agda if we're not going to fix it here.

@Rylan12
Copy link
Member

Rylan12 commented Jul 29, 2020

I think that's a reasonable requirements to stick to. In this case, though, there is an issue open (#55253).

@SMillerDev
Copy link
Member

#55253 isn't really an issue about agda being broken though. That one is meant to guide the migration.

@Rylan12
Copy link
Member

Rylan12 commented Jul 29, 2020

But the reason agda is broken is that cabal v1 is deprecated, so I think it's implied that all formulae in that issue will be broken.

Maybe that's not the case. If it's not, then there definitely should be an issue or PR for it.

@Bo98
Copy link
Member

Bo98 commented Jul 29, 2020

  1. going well

no

  1. will be done soon

A quick temporary fix is to make it use "v1-install" directly (and no sandbox).

"v2-install" requires either the MacPorts-style hack or wrapper scripts for every binary, both of which should have some brew helpers to accomodate.

A hybrid approach of v2-installing dependencies and not using Cabal for the actual agda build is another possibility I'm investigating.

I planned to discuss Cabal a bit at the next maintainer call, but I should probably not wait until then and figure something out this week. I should have dealt with it weeks ago since it's my fault really that the test fails.

@Rylan12 Rylan12 mentioned this pull request Jul 31, 2020
@BrewTestBot BrewTestBot added the missing license Formula has a missing license which should be added label Jul 31, 2020
@dawidd6 dawidd6 removed the missing license Formula has a missing license which should be added label Jul 31, 2020
@miccal
Copy link
Contributor Author

miccal commented Aug 1, 2020

Agda issue reported in #58984

@miccal
Copy link
Contributor Author

miccal commented Aug 2, 2020

@Rylan12, @SMillerDev and @Bo98 I rebased and the only failure now is agda.

Thanks.

@BrewTestBot
Copy link
Member

:shipit: @Rylan12 has triggered a merge.

@Rylan12
Copy link
Member

Rylan12 commented Aug 2, 2020

Thanks, @miccal!

@miccal miccal deleted the unbound-1.11.0 branch August 2, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants