Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nest 2.20.0 (new formula) #56545

Closed
wants to merge 1 commit into from
Closed

nest 2.20.0 (new formula) #56545

wants to merge 1 commit into from

Conversation

tammoippen
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Continuing the migration from in #21561.

Migrating because of: Homebrew/homebrew-science#6331

@alebcay alebcay added the new formula PR adds a new formula to Homebrew/homebrew-core label Jun 19, 2020
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@tammoippen tammoippen deleted the nest2.20.0 branch June 21, 2020 16:33
@laurentperrinet
Copy link
Contributor

by curiosity, why use python@3.8 rather than the standard version available now?

@tammoippen
Copy link
Contributor Author

@laurentperrinet Homebrew is in transition to python 3.8 (#47274) - at some point it will be the standard version ;). Further all dependencies like numpy, scipy, etc are build already with python@3.8, hence nest / PyNEST need to be build with python@3.8 as well - otherwise we have to vendor (build our own) versions of these dependencies.

@laurentperrinet
Copy link
Contributor

got it thanks. another reason to switch to python@3.8 before the official transition date :-)

thanks, Laurent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants