Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc@8.8: migrate to python@3.8 #54771

Merged
merged 1 commit into from
May 17, 2020
Merged

ghc@8.8: migrate to python@3.8 #54771

merged 1 commit into from
May 17, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented May 16, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@iMichka iMichka mentioned this pull request May 16, 2020
jonchang
jonchang previously approved these changes May 16, 2020
@jonchang jonchang requested review from jonchang and removed request for jonchang May 16, 2020 09:38
@jonchang
Copy link
Contributor

@Bo98 do these need to build dependents from source?

@jonchang jonchang dismissed their stale review May 16, 2020 09:40

didnt build dependents from source

@Bo98
Copy link
Member

Bo98 commented May 16, 2020

For a pull request like this which only changes a build time dependency and should have no effect on how it behaves at runtime, it should be fine.

I believe Python is only used here for docs and tests.

@iMichka
Copy link
Member

iMichka commented May 16, 2020

Yes, we do not need to bump the revision here, as this is just a build time dependency. @Rylan12 can you remove the revision 1 line?

@Rylan12
Copy link
Member Author

Rylan12 commented May 16, 2020

Yep! Thanks for the catch @jonchang.

@jonchang jonchang merged commit e977f8e into Homebrew:master May 17, 2020
@Rylan12 Rylan12 deleted the ghc-python38 branch May 17, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants