Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

augustus: don't hardcode gcc version #54691

Closed
wants to merge 1 commit into from

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented May 14, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Did not bump revision because #{Formula["gcc"].version_suffix} should resolve to 9 right now anyways.

Related to #54364.

@DesWurstes
Copy link
Contributor

Isn't this better? (For consistency too)

with_env("HOMEBREW_CC" => Formula["gcc"].opt_bin/"gcc-#{Formula["gcc"].version_suffix}") 

@alebcay
Copy link
Member Author

alebcay commented May 14, 2020

You're right, that is more consistent with where it's used in some other places in Homebrew.

@alebcay alebcay force-pushed the augustus-gcc-version-suffix branch from 4cdf35b to c1a0437 Compare May 14, 2020 17:27
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants