Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradio: deprecate formula #54668

Merged
merged 1 commit into from
May 18, 2020
Merged

gradio: deprecate formula #54668

merged 1 commit into from
May 18, 2020

Conversation

Amar1729
Copy link
Contributor

@Amar1729 Amar1729 commented May 13, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • n/a Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • n/a Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • n/a Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Looks like gradio has been deprecated upstream: https://github.com/haecker-felix/Gradio

Owner/Readme points towards new project Shortwave (which actually should maybe be a cask rather than a formula anyway).

This is also one of the leftover formula depending on python (#47274).

@zachauten
Copy link
Contributor

looks like gradio's only had a couple installs in the last month https://formulae.brew.sh/formula/gradio#default

@chenrui333 chenrui333 added the marked for removal/rejection PR is probably going to be closed or formula deleted label May 14, 2020
@iMichka
Copy link
Member

iMichka commented May 14, 2020

Hi. We do not delete the files right away now. Please use the disable DSL; see for example #54471.

The file will be removed later, probably after a few months.

@SMillerDev
Copy link
Member

Can we mark it deprecated with the date first?

@iMichka
Copy link
Member

iMichka commented May 14, 2020

Yes, even better; as it somewhat still works. The deprecation date is 16 Nov 2019.

@Amar1729 Amar1729 changed the title gradio: remove deprecated formula gradio: deprecate formula May 14, 2020
@iMichka iMichka mentioned this pull request May 15, 2020
@iMichka iMichka merged commit d918d1a into Homebrew:master May 18, 2020
@iMichka
Copy link
Member

iMichka commented May 18, 2020

Thanks @Amar1729 !

@Amar1729 Amar1729 deleted the patch-1 branch May 19, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marked for removal/rejection PR is probably going to be closed or formula deleted python-3.8-migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants