Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shocco: delete #47366

Merged
merged 1 commit into from
Dec 1, 2019
Merged

shocco: delete #47366

merged 1 commit into from
Dec 1, 2019

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Dec 1, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@issyl0 issyl0 requested a review from bayandin December 1, 2019 17:43
@issyl0
shocco: delete
57910ff 
- According to [its GitHub repo](https://github.com/rtomayko/shocco),
  this software is no longer maintained as of 2017.
- It's had 4 installs over the past 90 days, and 19 over the past 365
  days.
- It third from the bottom of our [list of formulae that need building with Python
  3.8](Homebrew#47274).
@issyl0 issyl0 added the marked for removal/rejection PR is probably going to be closed or formula deleted label Dec 1, 2019
@issyl0
Copy link
Member Author

issyl0 commented Dec 1, 2019 •
edited
Loading

The force-push was because my local checkout of Homebrew/homebrew-core was wayyy behind. Also Jenkins was confused.

chenrui333
chenrui333 approved these changes Dec 1, 2019
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

@issyl0 issyl0 merged commit 93965c1 into Homebrew:master Dec 1, 2019
@issyl0 issyl0 deleted the remove-shocco branch December 1, 2019 22:36
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@bayandin bayandin Awaiting requested review from bayandin

Assignees
No one assigned
Labels
marked for removal/rejection PR is probably going to be closed or formula deleted outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@issyl0 @chenrui333