-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python@3.8 3.8.0 (new formula) #47273
Conversation
Hmm might need to be careful and think about dependency trees here. If a Python 3.7 formula depends on a Python 3.8 formula (or vice versa), there's gonna be problems. I'm not sure how many forumlae are in that situation. One thing for sure is Cython. If we don't migrate everything depending on Cython together, we're gonna have to have two Cython formulae - one for Python 3.7 and one for Python 3.8. How many formulae are there depending on Cython? |
There's actually a lot less depending on Cython than I thought. We'll need to migrate that and their dependants (recursively) together, either now or later on. |
Here it is, the list of formulae recursively depending on
|
As a resource doesn't really matter since updating the Cython formula won't mandate updating those that use Cython as a resource at the same time. As a formula it does matter. And it needs to be done recursively (except in cases where a formula doesn't use any Python at all): You then need to watch out if anything on that list depends on another Python formula that doesn't itself depend on Cython - that too will need to be updated. Not sure of a nice way to get such list. Cython is just an example of course - there's others too. |
4b9a7d5
to
dcc332c
Compare
This PR will land |
dcc332c
to
aa907ad
Compare
Can an owner add the [python] label to this PR? |
It doesn't really change anything but here you go |
aa907ad
to
d55149b
Compare
Is there anything still needed here? I understand it's just step 1 in a larger effort to get to |
d55149b
to
f94c019
Compare
I think we should add the caveats back (and adapt the paths in the caveat). Except that, everything looks good for me. |
f94c019
to
ebc9181
Compare
Thanks @iMichka, added caveats back |
brew install python@2 | ||
|
||
You can install Python packages with | ||
pip3 install <package> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is keg_only, I guess that the pip3 path should also be something like #{HOMEBREW_PREFIX/"bin/pip3"}
?
Let's merge this as-is once the build is done and green :) |
I'll open another PR to fix the caveats, I noticed that some information in there is wrong. |
Here is the PR to update the caveat: #47984 |
Thanks @iMichka! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see this move forward!!
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?This PR adds
python@3.8
formulaand migrates 10 most popular depending onpython
formulae (butglib
)