Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm@8: fix C++ compilation for Mojave and Catalina #45960

Closed
wants to merge 1 commit into from
Closed

llvm@8: fix C++ compilation for Mojave and Catalina #45960

wants to merge 1 commit into from

Conversation

smorimoto
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Port from #45693. Thank you @jamiesnape.

Related issue and PR: #45061 and #45304.

@smorimoto smorimoto mentioned this pull request Oct 29, 2019
Closed
@smorimoto
Copy link
Contributor Author

@BrewTestBot test this please!

@fxcoudert
Copy link
Member 

==> /usr/local/Cellar/llvm@8/8.0.1_1/bin/scan-build clang++ scanbuildtest.cpp 2>&1
Error: llvm@8: failed
An exception occurred within a child process:
  Test::Unit::AssertionFailedError: <0> expected but was
<1>.

@smorimoto
Copy link
Contributor Author

smorimoto commented Nov 1, 2019 •
edited
Loading

I wonder why latest llvm and llvm@7 succeeded and llvm@8 failed. Let's take a closer look at it anyway.

@jamiesnape
Copy link
Contributor

Maybe something to do with this? llvm/llvm-project@1932788#diff-0c7516e3549ab095e9bef2a491937235

@smorimoto
Copy link
Contributor Author

Maybe scan-build could not find clang. I hope test will run correctly with last commit.

@smorimoto
Copy link
Contributor Author

Test passed!

@smorimoto
Copy link
Contributor Author

Squashed.

@smorimoto
Copy link
Contributor Author

Ready to review (or merge?)

chenrui333
chenrui333 approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Nov 2, 2019
@chenrui333 chenrui333 closed this in 5d4da28 Nov 2, 2019
@smorimoto smorimoto deleted the llvm@8-sysroot branch November 3, 2019 04:22
@smorimoto
Copy link
Contributor Author

👍

@lock lock bot added the outdated PR was locked due to age label Jan 3, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smorimoto @fxcoudert @jamiesnape @chenrui333