Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel 0.24.1 #38651

Closed
wants to merge 1 commit into from
Closed

bazel 0.24.1 #38651

wants to merge 1 commit into from

Conversation

hawkingrei
Copy link
Contributor

@hawkingrei hawkingrei commented Apr 4, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@SMillerDev
Copy link
Member

It's failing on macOS Sierra.

@SMillerDev SMillerDev added the build failure CI fails while building the software label Apr 4, 2019
@zbeekman
Copy link
Contributor

zbeekman commented Apr 9, 2019

Specifically:

==> ./compile.sh
Building Bazel from scratch....../usr/bin/xcrun clang -fobjc-arc -framework CoreServices -framework Foundation -o /private/tmp/bazel_7qI7yfV0/archive/_embedded_binaries/xcode-locator tools/osx/xcode_locator.m
tools/osx/xcode_locator.m:180:64: error: no visible @interface for 'NSDictionary' declares the selector 'initWithContentsOfURL:error:'
    NSDictionary *versionPlistContents = [[NSDictionary alloc] initWithContentsOfURL:versionPlistUrl
                                          ~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
==> ./output/bazel --output_user_root /private/tmp/bazel-20190404-95358-1icibs5/output_user_root build --host_java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8 --java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8 --host_javabase=@bazel_tools//tools/jdk:jdk --javabase=@bazel_tools//tools/jdk:jdk scripts:bash_completion
Failed to execute: ./output/bazel

bazel-io pushed a commit to bazelbuild/bazel that referenced this pull request Apr 19, 2019
Homebrew's CI is breaking on 10.12 (Sierra), for Bazel 0.24+ due to the signature used for NSDictionary:initWithContentsOfURL introduced in the fix for #7371.

This signature with an error parameter is only available on 10.13+ (High Sierra). Here's Apple's documentation: https://developer.apple.com/documentation/foundation/nsdictionary/1416069-initwithcontentsofurl?language=objc

The Homebrew issue:
Homebrew/homebrew-core#38651

Closes #8068.

PiperOrigin-RevId: 244357959
dkelmer pushed a commit to bazelbuild/bazel that referenced this pull request Apr 25, 2019
Homebrew's CI is breaking on 10.12 (Sierra), for Bazel 0.24+ due to the signature used for NSDictionary:initWithContentsOfURL introduced in the fix for #7371.

This signature with an error parameter is only available on 10.13+ (High Sierra). Here's Apple's documentation: https://developer.apple.com/documentation/foundation/nsdictionary/1416069-initwithcontentsofurl?language=objc

The Homebrew issue:
Homebrew/homebrew-core#38651

Closes #8068.

PiperOrigin-RevId: 244357959
dkelmer pushed a commit to bazelbuild/bazel that referenced this pull request Apr 25, 2019
Homebrew's CI is breaking on 10.12 (Sierra), for Bazel 0.24+ due to the signature used for NSDictionary:initWithContentsOfURL introduced in the fix for #7371.

This signature with an error parameter is only available on 10.13+ (High Sierra). Here's Apple's documentation: https://developer.apple.com/documentation/foundation/nsdictionary/1416069-initwithcontentsofurl?language=objc

The Homebrew issue:
Homebrew/homebrew-core#38651

Closes #8068.

PiperOrigin-RevId: 244357959
dkelmer pushed a commit to bazelbuild/bazel that referenced this pull request Apr 25, 2019
Homebrew's CI is breaking on 10.12 (Sierra), for Bazel 0.24+ due to the signature used for NSDictionary:initWithContentsOfURL introduced in the fix for #7371.

This signature with an error parameter is only available on 10.13+ (High Sierra). Here's Apple's documentation: https://developer.apple.com/documentation/foundation/nsdictionary/1416069-initwithcontentsofurl?language=objc

The Homebrew issue:
Homebrew/homebrew-core#38651

Closes #8068.

PiperOrigin-RevId: 244357959
dkelmer pushed a commit to bazelbuild/bazel that referenced this pull request Apr 29, 2019
Homebrew's CI is breaking on 10.12 (Sierra), for Bazel 0.24+ due to the signature used for NSDictionary:initWithContentsOfURL introduced in the fix for #7371.

This signature with an error parameter is only available on 10.13+ (High Sierra). Here's Apple's documentation: https://developer.apple.com/documentation/foundation/nsdictionary/1416069-initwithcontentsofurl?language=objc

The Homebrew issue:
Homebrew/homebrew-core#38651

Closes #8068.

PiperOrigin-RevId: 244357959
@stale
Copy link

stale bot commented Apr 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Apr 30, 2019
@zbeekman
Copy link
Contributor

@BrewTestBot test this please

@stale stale bot removed the stale No recent activity label Apr 30, 2019
@jmhodges
Copy link
Contributor

jmhodges commented May 5, 2019

This was fixed in bazel 0.25, so we could use that to upgrade https://github.com/bazelbuild/bazel/releases/tag/0.25.0 (see bazelbuild/bazel@231270c )

@jmhodges
Copy link
Contributor

jmhodges commented May 5, 2019

Trying do this myself but I keep getting errors when running bump-formula-pr

Error: GitHub You must be logged in to do that.:The GitHub credentials in the macOS keychain may be invalid.
Clear them with:
  printf "protocol=https\nhost=github.com\n" | git credential-osxkeychain erase
Or create a personal access token:

The first command didn't fix the problem and I keep my bash_profile in the open so I can't put secrets in it. Would be cool to see 0.25.0 go in!

@zbeekman zbeekman mentioned this pull request May 7, 2019
@zbeekman
Copy link
Contributor

zbeekman commented May 7, 2019

@hawkingrei Thanks for opening this PR. Since bazel was broken, and they've released a new version with a fix I've created a new PR to replace this one. Thanks for your contributions to Homebrew!

@zbeekman zbeekman closed this May 7, 2019
@zbeekman
Copy link
Contributor

zbeekman commented May 7, 2019

(New PR is #39571)

@hawkingrei hawkingrei deleted the bazel_0.24.1 branch May 26, 2019 06:19
@lock lock bot added the outdated PR was locked due to age label Feb 13, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build failure CI fails while building the software outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants