Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go@1.11 1.11.5 (new formula) #37621

Closed
wants to merge 2 commits into from
Closed

Conversation

vincepri
Copy link

@vincepri vincepri commented Mar 5, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@vincepri vincepri changed the title Create go@1.11.rb go@1.11 1.11.5 Mar 5, 2019
@BrewTestBot
Copy link
Member

  • New formulae should not have a bottle do block

@SMillerDev SMillerDev added the new formula PR adds a new formula to Homebrew/homebrew-core label Mar 6, 2019
@SMillerDev
Copy link
Member

Could you add (new formula) at the end of the title/commit?
In addition to that, what's the need to ship this particular version as a seperate formula? Is it still supported by upstream?

@fxcoudert
Copy link
Member

We have too many Go versions in core, if we want to add this one we'd have to drop at least one older.

@fxcoudert fxcoudert added the legacy Relates to a versioned @ formula label Mar 6, 2019
@vincepri
Copy link
Author

vincepri commented Mar 6, 2019

@SMillerDev Sure can do, can you give some guidance on how to fix bottle do?
@fxcoudert Completely agree, I see there is still 1.4, 1.8 and 1.9, which have been deprecated. Go supports only N-2 releases as specified here https://golang.org/doc/devel/release.html.

@vincepri vincepri changed the title go@1.11 1.11.5 go@1.11 1.11.5 (new formula) Mar 6, 2019
@vincepri
Copy link
Author

vincepri commented Mar 6, 2019

@fxcoudert Let me know if I should remove the unsupported version as part of this PR or open a new one.

@fxcoudert
Copy link
Member

I think we were keeping go 1.4 because it's the last version that builds without bootstrap… but not sure if that makes sense to keep going forward.

I'd say: remove 1.4 and 1.8, which have low usage and are not supported.

@fxcoudert fxcoudert added the maintainer feedback Additional maintainers' opinions may be needed label Mar 7, 2019
Signed-off-by: Vince Prignano <vince@vincepri.com>
@vincepri
Copy link
Author

vincepri commented Mar 7, 2019

@fxcoudert Added a commit to remove the versions specified.

@fxcoudert fxcoudert requested a review from MikeMcQuaid March 8, 2019 15:27
@fxcoudert
Copy link
Member

@BrewTestBot test this please

@fxcoudert fxcoudert added ready to merge PR can be merged once CI is green and removed maintainer feedback Additional maintainers' opinions may be needed labels Mar 11, 2019
@fxcoudert
Copy link
Member

Build is failing on Sierra and High Sierra:

==> go build
../../godoc/redirect/redirect.go:22:2: cannot find package "golang.org/x/net/context/ctxhttp" in any of:
	/usr/local/Cellar/go@1.11/1.11.5/libexec/go/src/golang.org/x/net/context/ctxhttp (from $GOROOT)
	/private/tmp/go@1.11-20190311-9501-zj40qh/go/src/golang.org/x/net/context/ctxhttp (from $GOPATH)

@fxcoudert fxcoudert removed the ready to merge PR can be merged once CI is green label Mar 11, 2019
@vincepri
Copy link
Author

@fxcoudert Unfortunately I don't have Sierra/High Sierra to test. What do you think about removing those completely from the formula?

@fxcoudert
Copy link
Member

Thanks @vincepri for the pull request, build appeared to succeed in #38018 so we're going to merge that one.

@fxcoudert fxcoudert closed this Mar 20, 2019
@vincepri
Copy link
Author

Apologies, I forgot to follow-up. Thanks though!

@lock lock bot added the outdated PR was locked due to age label Apr 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants