-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go@1.11 1.11.5 (new formula) #37621
go@1.11 1.11.5 (new formula) #37621
Conversation
|
Could you add (new formula) at the end of the title/commit? |
We have too many Go versions in core, if we want to add this one we'd have to drop at least one older. |
@SMillerDev Sure can do, can you give some guidance on how to fix |
@fxcoudert Let me know if I should remove the unsupported version as part of this PR or open a new one. |
I think we were keeping go 1.4 because it's the last version that builds without bootstrap… but not sure if that makes sense to keep going forward. I'd say: remove 1.4 and 1.8, which have low usage and are not supported. |
Signed-off-by: Vince Prignano <vince@vincepri.com>
@fxcoudert Added a commit to remove the versions specified. |
@BrewTestBot test this please |
Build is failing on Sierra and High Sierra:
|
@fxcoudert Unfortunately I don't have Sierra/High Sierra to test. What do you think about removing those completely from the formula? |
Apologies, I forgot to follow-up. Thanks though! |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?